Please don't use "value" component to calculate the brightness of a color. #000081 is much darker than #808080. To decide, use qGray(). The threshold also needs to be higher than 128; I use 170, but this mostly depends on correctness of monitor gamma settings.

See https://stackoverflow.com/questions/3942878/how-to-decide-font-color-in-white-or-black-depending-on-background-color

Variables declared in 'for' are local, so just use 'color'.

The comment still says "struct". Maybe clarify that this list is actually used as a map.

(I guess since mapping would happen in both directions, using a QMap isn't useful?)

typos: of; selection

Sentence misses a full stop.

typo: selection

This sentence is confusing. I guess you wanted to write "if there are no named colors, the returned list is empty." (to clarify that it won't return the standard list).

Missing const, also the name should be innerColor with a capital C if we are following the code style from this file.

missing reference for innercolor ?

Maybe changing the logic to make it more simpler:

QRect colorRect = tv.toString().isEmpty() ? innerrect : QRect(innerrect.x(), innerrect.y() + innerrect.height() / 2, innerrect.width(), innerrect.height() / 2);

It's missing const

This is just a suggestion and not something that's necessary to do, but maybe it could help to create a simple class to replace QPair:

class KComboColor {
    Q_PROPERTY(QColor color MEMBER color)
    Q_PROPERTY(QString name MEMBER name)
public:
    QColor color;
    QString name;
}

Done!

Yes, reference not found for innercolor or innerColor

Done!

Done!

Done!

Done!

Done!

Done!

Done!

Done!

Good suggestion, I will be thinking how to do it as this would alter the use of lists within the code.

Done!

I would probably do what Kirigami does for ColorUtils::brightnessForColor here: ((0.299 * color.red() + 0.587 * color.green() + 0.114 * color.blue()) / 255) > 0.5 ? Qt::black : Qt::white

Using QMap would cause me a problem, consider the following code block:

for (int i = 0; i <STANDARD_PALETTE_SIZE; ++ i) {
                 if (standardColor (i) == color) {
                     q-> setCurrentIndex (i + 1);

I need variable i for iteration with the call q-> setCurrentIndex (i + 1) and this method would not be available with QMap.

Is a simple tuple list really the best way to represent colours? Knowing what most designers like, a better data structure would encapsulate named groups of optionally named colours.

I believe that yes, each color has its own representation, and the way it was proposed, if the color is not available, the name used is the hex value of the color.

Done!

Done!

Missing const.

missing const.

auto& as we just want a reference, avoids a copy constructor call each time.

auto& as we just want a reference, avoids a copy constructor call each time.

list.reserve(STANDARD_PALETTE_SIZE);