[applets/appmenu] Add search to global application menu
AbandonedPublic

Authored by cblack on May 6 2020, 2:34 AM.

Details

Reviewers
None
Group Reviewers
Plasma
VDG
Summary

The global application menu has a search field now

Test Plan

Diff Detail

Repository
R120 Plasma Workspace
Branch
cblack/appmenu-search (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 26476
Build 26494: arc lint + arc unit
cblack created this revision.May 6 2020, 2:34 AM
Restricted Application added a project: Plasma. · View Herald TranscriptMay 6 2020, 2:34 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
cblack updated this revision to Diff 82125.May 6 2020, 5:45 PM

Better search

cblack updated this revision to Diff 82138.May 6 2020, 6:35 PM

Fix some quirks

gikari added a subscriber: gikari.May 6 2020, 6:47 PM

Is it possible to integrate the search into the help menu, if it exists already or create an entry for it. Much like macOS does.

cblack added a comment.May 6 2020, 6:52 PM

Is it possible to integrate the search into the help menu, if it exists already or create an entry for it. Much like macOS does.

There's no reliable way to figure out which menu is the "help" one, and there's not a reliable way of modifying a menu for this kind of functionality besides appending a new entry to the end.

cblack updated this revision to Diff 82141.May 6 2020, 6:56 PM

Add better non-Wayland guards

cblack updated this revision to Diff 82144.May 6 2020, 7:17 PM

Clear search text on application change

nicolasfella added inline comments.
applets/appmenu/plugin/appmenumodel.cpp
246

Extract the list into a variable before iterating, else this might blow up

See https://github.com/KDE/clazy/blob/master/docs/checks/README-temporary-iterator.md

nicolasfella added inline comments.May 7 2020, 11:01 AM
applets/appmenu/plugin/appmenumodel.cpp
193

.isEmpty()

196

const

applets/appmenu/plugin/appmenumodel.h
70

const

73

const

cblack updated this revision to Diff 83175.May 29 2020, 7:41 PM
cblack marked 5 inline comments as done.

Address feedback

cblack added inline comments.May 29 2020, 7:41 PM
applets/appmenu/plugin/appmenumodel.h
70

actions are needed as non-const

wwestrop removed a subscriber: wwestrop.
trmdi added a subscriber: trmdi.May 30 2020, 3:47 PM

Can this be moved to krunner? In that case it can be used even when the user doesn't use global menu?

ognarb added a subscriber: ognarb.Sep 8 2020, 7:33 AM

What is the state of this MR?

Can this be moved to krunner? In that case it can be used even when the user doesn't use global menu?

I don't think think so, this search works in the app action menu items. Krunner is completely detached from applications.

@ngraham any thoughts perhaps ?

Putting it in KRunner could make at least a little bit of sense if it worked everywhere--i.e. with in-window menubars as well. However since it does not, I think the current location makes sense.

Could you move this to GitLab maybe?

cblack added a comment.Sep 8 2020, 6:46 PM

Putting it in KRunner could make at least a little bit of sense if it worked everywhere--i.e. with in-window menubars as well. However since it does not, I think the current location makes sense.

Could you move this to GitLab maybe?

https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/134

cblack abandoned this revision.Sep 8 2020, 6:46 PM