[kio-extras] Port some QRegExp usage to QRegularExpression
Needs ReviewPublic

Authored by ahmadsamir on Fri, Mar 20, 12:52 PM.

Details

Reviewers
dfaure
sitter
apol
Test Plan

Showing man pages in konqueror still works

Diff Detail

Repository
R320 KIO Extras
Branch
l-QRE (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 24256
Build 24274: arc lint + arc unit
ahmadsamir created this revision.Fri, Mar 20, 12:52 PM
Restricted Application added projects: Dolphin, Frameworks. · View Herald TranscriptFri, Mar 20, 12:52 PM
Restricted Application added a subscriber: kfm-devel. · View Herald Transcript
ahmadsamir requested review of this revision.Fri, Mar 20, 12:52 PM

(Also could some one with more power than me clang-format this whole repo (there's a clang-format.cmake in extra-cmake-modules)? just note that some hand-formatted char* definitions blow up :)).

Looks good to me, not that this means much with regular expressions. The lack of tests on this stuff makes me sad :((

Please don't touch kdsoap-ws-discovery-client though. It's not maintained here -> https://gitlab.com/caspermeijn/kdsoap-ws-discovery-client

Looks good to me, not that this means much with regular expressions. The lack of tests on this stuff makes me sad :((

Unit tests are indeed useful...

Please don't touch kdsoap-ws-discovery-client though. It's not maintained here -> https://gitlab.com/caspermeijn/kdsoap-ws-discovery-client

That's confusing; but OK, I'll revert that part of the diff.

Leave out kdsoap-ws-discovery-client, it's maintained somewhere else...

Please don't touch kdsoap-ws-discovery-client though. It's not maintained here -> https://gitlab.com/caspermeijn/kdsoap-ws-discovery-client

That's confusing; but OK, I'll revert that part of the diff.

Yeah, it's not ideal but the library is not API-stable so we need a fixed reference point. Do please make a merge request for it though, Casper is very responsive to MRs.

Please don't touch kdsoap-ws-discovery-client though. It's not maintained here -> https://gitlab.com/caspermeijn/kdsoap-ws-discovery-client

That's confusing; but OK, I'll revert that part of the diff.

Yeah, it's not ideal but the library is not API-stable so we need a fixed reference point. Do please make a merge request for it though, Casper is very responsive to MRs.

OK, will do, thanks for the pointer. :)