(Also could some one with more power than me clang-format this whole repo (there's a clang-format.cmake in extra-cmake-modules)? just note that some hand-formatted char* definitions blow up :)).

Looks good to me, not that this means much with regular expressions. The lack of tests on this stuff makes me sad :((

Please don't touch kdsoap-ws-discovery-client though. It's not maintained here -> https://gitlab.com/caspermeijn/kdsoap-ws-discovery-client

In D28161#634949, @sitter wrote:

Looks good to me, not that this means much with regular expressions. The lack of tests on this stuff makes me sad :((

Unit tests are indeed useful...

Please don't touch kdsoap-ws-discovery-client though. It's not maintained here -> https://gitlab.com/caspermeijn/kdsoap-ws-discovery-client

That's confusing; but OK, I'll revert that part of the diff.

In D28161#634951, @ahmadsamir wrote:

Please don't touch kdsoap-ws-discovery-client though. It's not maintained here -> https://gitlab.com/caspermeijn/kdsoap-ws-discovery-client

That's confusing; but OK, I'll revert that part of the diff.

Yeah, it's not ideal but the library is not API-stable so we need a fixed reference point. Do please make a merge request for it though, Casper is very responsive to MRs.

In D28161#634955, @sitter wrote:

In D28161#634951, @ahmadsamir wrote:

Please don't touch kdsoap-ws-discovery-client though. It's not maintained here -> https://gitlab.com/caspermeijn/kdsoap-ws-discovery-client

That's confusing; but OK, I'll revert that part of the diff.

Yeah, it's not ideal but the library is not API-stable so we need a fixed reference point. Do please make a merge request for it though, Casper is very responsive to MRs.

OK, will do, thanks for the pointer. :)

Ping.

Seems good to me