Make animation durations consistent with Kirigami values
AcceptedPublic

Authored by ngraham on Thu, Mar 19, 5:26 PM.

Details

Summary

Right now longDuration is 120ms and shortDuration is 24ms. This presents three problems:

  • The durations are far too fast, especially shortDuration, which is so fast that it seems like there is no animation at all.
  • The durations are not consistent with Kirigami, which uses 150 for short and 250 for long.
  • There is no longer value available, as with the one being added to Kirigami in D28143.

Accordingly, this patch makes the short and long values consistent with Kirigami's values,
and adds a new veryLongDuration value to match the one being added to Kirigami in D28143.

Diff Detail

Repository
R242 Plasma Framework (Library)
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ngraham created this revision.Thu, Mar 19, 5:26 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptThu, Mar 19, 5:26 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
ngraham requested review of this revision.Thu, Mar 19, 5:26 PM
ngraham updated this revision to Diff 78035.Thu, Mar 19, 6:27 PM

Don't forget kirigamiplasmastyle

ngraham updated this revision to Diff 78036.Thu, Mar 19, 6:28 PM

Forgot one more thing

mart accepted this revision.Fri, Mar 20, 3:38 PM
This revision is now accepted and ready to land.Fri, Mar 20, 3:38 PM
This revision was automatically updated to reflect the committed changes.
ngraham reopened this revision.Tue, Mar 24, 2:39 PM

I reverted this for now in e2a13e9ac79a8d8d8a7dfd0916f6826760b73165 because if we land it now before the companion Plasma patches are in, rolling release users will suffer from slow animations for a month. I will re-land it after Frameworks 5.69 is tagged so that it gets released with Frameworks 5.70, the version that Plasma 5.19 will depend on.

This revision is now accepted and ready to land.Tue, Mar 24, 2:39 PM