Stop multiplying duration values
AcceptedPublic

Authored by ngraham on Tue, Mar 24, 2:16 PM.

Details

Reviewers
cblack
Group Reviewers
VDG
Plasma
Summary

After D28144, some animations are now too long because they were inappropriately
multiplying a duration value. That's no longer necessary, so let's remove the
multiplication.

Depends on D28144

Test Plan

Various things that were a bit too slow before feel just right now

Diff Detail

Repository
R120 Plasma Workspace
Branch
use-standard-duration-values (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 24147
Build 24165: arc lint + arc unit
ngraham created this revision.Tue, Mar 24, 2:16 PM
Restricted Application added a project: Plasma. · View Herald TranscriptTue, Mar 24, 2:16 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Tue, Mar 24, 2:16 PM
cblack accepted this revision as: Plasma, cblack.Tue, Mar 24, 2:21 PM
cblack added a subscriber: cblack.

Code looks good to me, but I haven't looked at how these changes look visually.
These are where these changes will be visible, right?

  • Clicking a device in the system tray device list
  • System tray arrow

I'm not sure where you can see the changes to ActionButton.qml and UserDelegate.qml.

This revision is now accepted and ready to land.Tue, Mar 24, 2:21 PM

I'm not sure where you can see the changes to ActionButton.qml and UserDelegate.qml.

the lock, logout, and login screens

cblack accepted this revision.Tue, Mar 24, 5:21 PM