Differential D27811

[KConfigGui] Check font weight when clearing styleName property
ClosedPublic
Actions

Authored by ahmadsamir on Mar 3 2020, 6:46 PM.

Details

Reviewers
dfaure
davidedmundson
cfeck
ervin
meven
bport
Group Reviewers
Frameworks
Commits
R237:ec9522ae73ff: [KConfigGui] Check font weight when clearing styleName property
Summary

This is an addendum for commit a2774ff5b41987c3919a9e; making the check
tighter.

Test Plan

make && ctest

Diff Detail

Repository
R237 KConfig
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ahmadsamir created this revision.Mar 3 2020, 6:46 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptMar 3 2020, 6:46 PM
ahmadsamir requested review of this revision.Mar 3 2020, 6:46 PM
ervin added a reviewer: bport.Mar 5 2020, 3:19 PM
ervin added a comment.Mar 5 2020, 3:24 PM

This styleName thing is an endless amount of fun... The patch LGTM, I'll let others weight in though since it can have ramifications I might miss.

ahmadsamir added a comment.Mar 5 2020, 3:50 PM
In D27811#622885, @ervin wrote:

This styleName thing is an endless amount of fun... The patch LGTM, I'll let others weight in though since it can have ramifications I might miss.

Well this one is the tip of the ice berg, the berg itself was a2774ff5b41987c3919a9e :)

ervin added a comment.Mar 5 2020, 3:52 PM
In D27811#622916, @ahmadsamir wrote:
In D27811#622885, @ervin wrote:

This styleName thing is an endless amount of fun... The patch LGTM, I'll let others weight in though since it can have ramifications I might miss.

Well this one is the tip of the ice berg, the berg itself was a2774ff5b41987c3919a9e :)

Yeah I know but we still need to account for this Qt "addition" at other places. It wasn't exactly transparent.

dfaure accepted this revision.Mar 6 2020, 10:54 PM
This revision is now accepted and ready to land.Mar 6 2020, 10:54 PM
Closed by commit R237:ec9522ae73ff: [KConfigGui] Check font weight when clearing styleName property (authored by ahmadsamir). · Explain WhyMar 23 2020, 4:20 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/gui/kconfiggroupgui.cpp (5 lines)

Diff 78264

View Options

src/gui/kconfiggroupgui.cpp

Loading...