Parts::ReadOnlyPart::completed signal is connected after openUrl has been called.
And it won't be emited, if openUrl was fast enough.
In this case openUrlFinished won't be emited which could, for example, cause the text not receiving a focus.
Details
Details
Diff Detail
Diff Detail
- Repository
- R167 Krusader
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 20425 Build 20443: arc lint + arc unit
Comment Actions
This is a right thing to do (connect before calling the emitting method). I just have a request to simplify the comment - something like "don't rely on return value of openUrl as the call is async in general". Thanks!
Comment Actions
Thanks, the proposal worked under Kubuntu 18.04 LTS and Kubuntu 19.10, other people can do their checks.
Comment Actions
Dear developers,
As code reviews in Phabricator are not going to be migrated to Gitlab (https://marc.info/?l=kde-core-devel&m=158909698416266&w=2) and this review is accepted since a long time ago, I'm going to do the git push if there is no objection. Thanks for all the developing and testing!
Comment Actions
Taking into account the latest messages here, and after several months of using this helpful commit, I've published the commit before the Phabricator to Gitlab migration started. Please, feel free to suggest or improve whatever you consider.