Remove unrequired private declarations for taglibextractor
Needs ReviewPublic

Authored by astippich on Mon, Nov 25, 10:46 AM.

Details

Reviewers
bruns
ngraham
mgallien
Group Reviewers
Baloo
Summary

They do not need to be declared in the header

Diff Detail

Repository
R286 KFileMetaData
Branch
cleanupTagLib
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 19203
Build 19221: arc lint + arc unit
astippich created this revision.Mon, Nov 25, 10:46 AM
Restricted Application added projects: Frameworks, Baloo. · View Herald TranscriptMon, Nov 25, 10:46 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
astippich requested review of this revision.Mon, Nov 25, 10:46 AM
ngraham accepted this revision.Mon, Nov 25, 3:21 PM
This revision is now accepted and ready to land.Mon, Nov 25, 3:21 PM
bruns requested changes to this revision.Tue, Nov 26, 11:39 PM
bruns added inline comments.
src/extractors/taglibextractor.cpp
97

This puts readGenericProperties(...) with external linkage in the global namespace.

Put the private helpers in an anonymous namespace (and also include extractAudioProperties(...) in it).

This revision now requires changes to proceed.Tue, Nov 26, 11:39 PM
astippich added inline comments.Wed, Nov 27, 8:12 AM
src/extractors/taglibextractor.cpp
97

Urgh, that was the plan actually. I could swear I've done that.

astippich updated this revision to Diff 70398.Wed, Nov 27, 8:20 AM
  • put all helper functions into anonymous namespace