They do not need to be declared in the header
Details
Details
- Reviewers
bruns ngraham mgallien - Group Reviewers
Baloo - Commits
- R286:f66662fea112: Remove unrequired private declarations for taglibextractor
Diff Detail
Diff Detail
- Repository
- R286 KFileMetaData
- Branch
- cleanupTagLib
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 19203 Build 19221: arc lint + arc unit
| src/extractors/taglibextractor.cpp | ||
|---|---|---|
| 97 | This puts readGenericProperties(...) with external linkage in the global namespace. Put the private helpers in an anonymous namespace (and also include extractAudioProperties(...) in it). | |
| src/extractors/taglibextractor.cpp | ||
|---|---|---|
| 97 | Urgh, that was the plan actually. I could swear I've done that. | |