[Folder View] Add subtle shadows to icons
ClosedPublic

Authored by ngraham on Mon, Sep 9, 4:52 PM.

Details

Summary

Folder View items currently have shadows behind their labels, but not their icons.

This patch adds a very subtle shadow for the icons as well, which improves contrast
for some backgrounds and just looks classy IMO. :)

FEATURE: 411607
FIXED-IN: 5.17.0

Test Plan

Before:


After:

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ngraham created this revision.Mon, Sep 9, 4:52 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMon, Sep 9, 4:52 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Mon, Sep 9, 4:52 PM
filipf accepted this revision.Mon, Sep 9, 5:02 PM
filipf added a subscriber: filipf.

Tried it out, I like the way it looks.

This revision is now accepted and ready to land.Mon, Sep 9, 5:02 PM
ndavis accepted this revision.Mon, Sep 9, 5:18 PM
ndavis added a subscriber: ndavis.

+1

cfeck added a subscriber: cfeck.Mon, Sep 9, 6:58 PM

Isn't Qt Quick amazing?

GB_2 added a subscriber: GB_2.Mon, Sep 9, 6:59 PM

Isn't Qt Quick amazing?

Indeed!

broulik added a subscriber: broulik.Mon, Sep 9, 8:14 PM

Can you check whether it's works with software rendering - we don't want desktop icons to entirely disappear in this case.

Ah never mind. It's in the if check like the label. Nice!

This revision was automatically updated to reflect the committed changes.