Differential D23803

[Folder View] Add subtle shadows to icons
ClosedPublic
Actions

Authored by ngraham on Sep 9 2019, 4:52 PM.

Details

Reviewers
hein
filipf
ndavis
Group Reviewers
Plasma
VDG
Commits
R119:37469c7dd02d: [Folder View] Add subtle shadows to icons
Summary

Folder View items currently have shadows behind their labels, but not their icons.

This patch adds a very subtle shadow for the icons as well, which improves contrast
for some backgrounds and just looks classy IMO. :)

FEATURE: 411607
FIXED-IN: 5.17.0

Test Plan

Before:


After:

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ngraham created this revision.Sep 9 2019, 4:52 PM
Restricted Application added a project: Plasma. · View Herald TranscriptSep 9 2019, 4:52 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Sep 9 2019, 4:52 PM
filipf accepted this revision.Sep 9 2019, 5:02 PM
filipf added a subscriber: filipf.

Tried it out, I like the way it looks.

This revision is now accepted and ready to land.Sep 9 2019, 5:02 PM
ndavis accepted this revision.Sep 9 2019, 5:18 PM
ndavis added a subscriber: ndavis.

+1

cfeck added a subscriber: cfeck.Sep 9 2019, 6:58 PM

Isn't Qt Quick amazing?

GB_2 added a subscriber: GB_2.Sep 9 2019, 6:59 PM
In D23803#528128, @cfeck wrote:

Isn't Qt Quick amazing?

Indeed!

broulik added a subscriber: broulik.Sep 9 2019, 8:14 PM

Can you check whether it's works with software rendering - we don't want desktop icons to entirely disappear in this case.

broulik added a comment.Sep 9 2019, 8:14 PM

Ah never mind. It's in the if check like the label. Nice!

Closed by commit R119:37469c7dd02d: [Folder View] Add subtle shadows to icons (authored by ngraham). · Explain WhySep 11 2019, 2:56 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 65851

View Options

containments/desktop/package/contents/ui/FolderItemDelegate.qml

Loading...