Revamp Kirigami.AboutPage
Needs RevisionPublic

Authored by hein on Aug 1 2019, 1:03 AM.


  • Use a FormLayout to work nicely in both portrait and landscape orientations
  • Don't use an AbstractCard for the person delegate, it's very jarring in this design
  • Fix app description not having word wrap (breaks on portrait)
  • Improve inter-section spacing
  • Fix empty author email addresses showing as "Name <>"
  • Fix scrollbar length if a Kirigami.Page doesn't set any actions (and don't load a gigantic subtree of unnecessary objects into the page)
  • If an app uses Kirigami.AbstractApplicationWindow and doesn't have a pageStack, don't have the license delegate be a LinkButton that operates on one and causes an error
  • Add a fallback to KAboutData::componentName for the program icon - KAboutData::programIconName is deprecated, there's no QML accessor for its replacement QGuiApplication::setWindowIcon yet, but KAboutData::programIconName falls back to componentName already (it fails because KAboutData::programIconName isn't a qprop, but I don't feel like adding it to KCoreAddons for a deprecated thing while componentName is not deprecated)

Diff Detail

R169 Kirigami
No Linters Available
No Unit Test Coverage
Build Status
Buildable 14629
Build 14647: arc lint + arc unit
hein created this revision.Aug 1 2019, 1:03 AM
Restricted Application added a project: Kirigami. · View Herald TranscriptAug 1 2019, 1:03 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
hein requested review of this revision.Aug 1 2019, 1:03 AM
hein added a comment.Aug 1 2019, 1:04 AM



hein added a comment.Aug 1 2019, 1:07 AM


Material style:

ngraham accepted this revision.Aug 1 2019, 1:07 AM
ngraham added a subscriber: ngraham.

Super duper better now.

This revision is now accepted and ready to land.Aug 1 2019, 1:07 AM
hein added a reviewer: leinir.Aug 1 2019, 1:09 AM
hein updated this revision to Diff 62883.Aug 1 2019, 1:49 AM

Don't hit Kirigami.Label (deprecated)

leinir accepted this revision.Aug 1 2019, 8:54 AM

While swapping out the card for straight up a rowlayout might[1] effectively look like a workaround for the weirdness in that bit... this really just looks better anyway ;) Go for it :D

[1] to someone who's tried to fix that bit before - D18180 - not in general :) once this is landed, i'll abandon that diff

nicolasfella requested changes to this revision.Aug 2 2019, 1:53 PM
nicolasfella added a subscriber: nicolasfella.

This breaks the display of main actions on mobile

This revision now requires changes to proceed.Aug 2 2019, 1:53 PM
hein added a comment.Aug 2 2019, 1:54 PM

I'll remove that part of the patch later tonight and talk Marco into fixing it differently.

can this be closed?