- Use a FormLayout to work nicely in both portrait and landscape orientations
- Don't use an AbstractCard for the person delegate, it's very jarring in this design
- Fix app description not having word wrap (breaks on portrait)
- Improve inter-section spacing
- Fix empty author email addresses showing as "Name <>"
- Fix scrollbar length if a Kirigami.Page doesn't set any actions (and don't load a gigantic subtree of unnecessary objects into the page)
- If an app uses Kirigami.AbstractApplicationWindow and doesn't have a pageStack, don't have the license delegate be a LinkButton that operates on one and causes an error
- Add a fallback to KAboutData::componentName for the program icon - KAboutData::programIconName is deprecated, there's no QML accessor for its replacement QGuiApplication::setWindowIcon yet, but KAboutData::programIconName falls back to componentName already (it fails because KAboutData::programIconName isn't a qprop, but I don't feel like adding it to KCoreAddons for a deprecated thing while componentName is not deprecated)
Details
Details
- Reviewers
mart apol ngraham leinir nicolasfella - Group Reviewers
Frameworks VDG
Diff Detail
Diff Detail
- Repository
- R169 Kirigami
- Branch
- aboutpage
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 14629 Build 14647: arc lint + arc unit
Comment Actions
While swapping out the card for straight up a rowlayout might[1] effectively look like a workaround for the weirdness in that bit... this really just looks better anyway ;) Go for it :D
[1] to someone who's tried to fix that bit before - D18180 - not in general :) once this is landed, i'll abandon that diff
Comment Actions
I'll remove that part of the patch later tonight and talk Marco into fixing it differently.