Fix layout issues in the AboutPage personDelegate component
Needs RevisionPublic

Authored by leinir on Jan 11 2019, 11:15 AM.

Details

Reviewers
mart
Group Reviewers
Kirigami
Summary

Without this patch, a couple of somewhat odd layout issues would happen in the person delegate when the application was resized

  • Not so oddly, as the label was not set to wrap, text would overflow on the right
  • More oddly, the initial layout would be entirely reasonable, but once resizing happened, the items would jump around and you ended up with something which was offset toward the bottom
  • This further adds the contributor's task to the delegate (not vital, just thought that would be nice to have in there)

Diff Detail

Repository
R169 Kirigami
Lint
Lint Skipped
Unit
Unit Tests Skipped
leinir created this revision.Jan 11 2019, 11:15 AM
Restricted Application added a subscriber: plasma-devel. ยท View Herald TranscriptJan 11 2019, 11:15 AM
leinir requested review of this revision.Jan 11 2019, 11:15 AM

Before (initial):

Before (after resizing):

After (after resizing):

leinir edited the summary of this revision. (Show Details)Jan 11 2019, 11:18 AM
mart requested changes to this revision.Jan 11 2019, 11:30 AM
mart added a subscriber: mart.

the bug is legit..
however i think it should be tried harder to avoid manual layouting, there must be a legit problem somewhere that this is triggering, i would like more investigation on it

This revision now requires changes to proceed.Jan 11 2019, 11:30 AM