dporobic (Damir Porobic)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Jan 26 2017, 10:32 AM (138 w, 8 h)
Availability
Available

Recent Activity

Jul 7 2019

dporobic committed R1031:f07e51e281a7: Add cmake uninstall target fix #47 (authored by dporobic).
Add cmake uninstall target fix #47
Jul 7 2019, 1:01 PM
dporobic committed R1031:326b93505525: Update changelog (authored by dporobic).
Update changelog
Jul 7 2019, 1:01 PM
dporobic committed R1031:f038c2fceccb: Make numbering tool number part of shape #46 (authored by dporobic).
Make numbering tool number part of shape #46
Jul 7 2019, 1:01 PM

Mar 14 2019

dporobic committed R1031:746a87fef678: Lower alpha for marker tools (authored by dporobic).
Lower alpha for marker tools
Mar 14 2019, 3:08 PM

Feb 25 2019

dporobic committed R1031:759f5f7cf9fc: Update changelog (authored by dporobic).
Update changelog
Feb 25 2019, 9:50 PM
dporobic committed R1031:6794f4f13ebd: Set blurRadiusWidget to nullptr in constructor (authored by dporobic).
Set blurRadiusWidget to nullptr in constructor
Feb 25 2019, 9:50 PM
dporobic committed R1031:ce56f7b63580: Pass blur properties to blur tool #25 (authored by dporobic).
Pass blur properties to blur tool #25
Feb 25 2019, 7:35 AM
dporobic committed R1031:fdb5d2bb94c2: Add new picker to annotator for blur radius and add blur radius to config #25 (authored by dporobic).
Add new picker to annotator for blur radius and add blur radius to config #25
Feb 25 2019, 7:35 AM
dporobic added a comment to T6321: [WISH] Create a quick image editor for Spectacle.

kImageAnnotator got its KDE Repo https://cgit.kde.org/libkimageannotator.git/

Feb 25 2019, 7:35 AM · VDG, Spectacle

Feb 23 2019

dporobic committed R1031:9263074e95ef: Increment numbers when copyping number items (authored by dporobic).
Increment numbers when copyping number items
Feb 23 2019, 2:14 PM
dporobic committed R1031:ae1e5d88f716: Update changelog (authored by dporobic).
Update changelog
Feb 23 2019, 2:14 PM

Feb 15 2019

dporobic added a comment to T6321: [WISH] Create a quick image editor for Spectacle.

Should we move kColorPicker to KDE infrastructure too?
https://github.com/DamirPorobic/kColorPicker

Feb 15 2019, 9:40 AM · VDG, Spectacle

Feb 6 2019

dporobic added a comment to T6321: [WISH] Create a quick image editor for Spectacle.

Ok, lets start with the repository (I prefer GitLab as I have some experience with it) and bug tracker. Where can I log a sysadmin task?

Feb 6 2019, 10:04 AM · VDG, Spectacle
dporobic added a comment to T6321: [WISH] Create a quick image editor for Spectacle.

What exactly do you mean with none-KDE version?

Feb 6 2019, 8:22 AM · VDG, Spectacle
dporobic added a comment to T6321: [WISH] Create a quick image editor for Spectacle.

I've finished the work on the shared library stuff and I'm already using it in ksnip, where you can test the latest version. Guess as @gregormi said, someone should probably start porting it to KDE infrastructure. I'm currently still working on some bugs and and new features so if someone has spare time, that is probably where to start @ngraham .

Feb 6 2019, 8:15 AM · VDG, Spectacle

Aug 27 2018

dporobic added a comment to T6321: [WISH] Create a quick image editor for Spectacle.

Hey Nate,

Aug 27 2018, 4:33 PM · VDG, Spectacle

Aug 17 2018

dporobic added a comment to T6321: [WISH] Create a quick image editor for Spectacle.

I have disabled the shadow for marker in the recent version and also added some different default colors for the tools. The build error that we had is also fixed.
Thanks for the tip with deepin-screenshot, I'll have a look into it.

Aug 17 2018, 6:33 AM · VDG, Spectacle

Jun 24 2018

dporobic added a comment to T6321: [WISH] Create a quick image editor for Spectacle.

Yeah, it's a bit odd when the handles indicate all items will be affected, while actually only one item will be resized.

I've fixed that now, hiding only the one that is currently resizing.

Jun 24 2018, 5:42 PM · VDG, Spectacle

Jun 10 2018

dporobic added a comment to T6321: [WISH] Create a quick image editor for Spectacle.

The only thing that's a bit inconsistent is that for moving the handles disappear on mouse-down already (like in Gwenview), but for resizing they hide only when starting to move the cursor (unlike in Gwenview). I'd prefer the former behaviour.

Jun 10 2018, 4:59 PM · VDG, Spectacle

Jun 5 2018

dporobic added a comment to T6321: [WISH] Create a quick image editor for Spectacle.

@rkflx thanks for confirming.

Jun 5 2018, 8:20 PM · VDG, Spectacle

Jun 4 2018

dporobic added a comment to T6321: [WISH] Create a quick image editor for Spectacle.

First I though about going with the second option but got to the same point you got in your edit. Then I remembered about about translating the painter which I read bout in a Qt bug and this could actually work, here the result:

Jun 4 2018, 6:14 PM · VDG, Spectacle

Jun 3 2018

dporobic added a comment to T6321: [WISH] Create a quick image editor for Spectacle.

I don't know if I get you correctly but to me this looks like an Antialiasing issue.
Here with enabled Antialiasing

Jun 3 2018, 9:42 AM · VDG, Spectacle
dporobic added a comment to T6321: [WISH] Create a quick image editor for Spectacle.
In T6321#145897, @rkflx wrote:

Thanks logging those issues! (Once the code lives in KDE's repos, we should probably use tasks on Phabricator for tracking…)

Sure, for now I only use them for myself and it's easier for me to track them in github, and the project lives there currently.

Jun 3 2018, 8:10 AM · VDG, Spectacle

Jun 2 2018

dporobic added a comment to T6321: [WISH] Create a quick image editor for Spectacle.

I noticed a more general problem which might be related: Try drawing straight lines (modifier FTW ;) with 1/2/3/4px width next to each other and look at them with KMag. They are not really aligned to the pixel grid, so Qt uses anti-aliasing, resulting in different colours and line widths. I think that's important to solve first, and afterwards focus on polishing the rectangle outlines or try a different approach if that fails.

Jun 2 2018, 1:01 PM · VDG, Spectacle

May 21 2018

dporobic added a comment to T6321: [WISH] Create a quick image editor for Spectacle.

@rkflx do you have a CI that builds on every commit? xD
That was another refactoring, should be working again.

May 21 2018, 7:49 AM · VDG, Spectacle

May 10 2018

dporobic added a comment to T6321: [WISH] Create a quick image editor for Spectacle.

@rkflx the slow test build should be fixed now. The initial approach has build all the source for every source file, now we build the source as a library once and link it to every test.

May 10 2018, 10:10 AM · VDG, Spectacle
dporobic added a comment to T6321: [WISH] Create a quick image editor for Spectacle.

@rkflx are you using latest version? I have fixed those error yesterday commit

May 10 2018, 8:19 AM · VDG, Spectacle

Apr 22 2018

dporobic added a comment to T6321: [WISH] Create a quick image editor for Spectacle.

It's not obvious enough. You could have just changed the colours of those items to a lighter shade.

It's not the same, with this approach you see selected items that are hidden behind other items and the color could be any color of course.

Apr 22 2018, 11:03 AM · VDG, Spectacle

Apr 20 2018

dporobic added a comment to T6321: [WISH] Create a quick image editor for Spectacle.

@huoni how about something like this for selected items:

Apr 20 2018, 5:03 PM · VDG, Spectacle

Apr 17 2018

dporobic added a comment to T6321: [WISH] Create a quick image editor for Spectacle.

Thanks for the feedback :)

Apr 17 2018, 8:00 PM · VDG, Spectacle

Apr 14 2018

dporobic added a comment to T6321: [WISH] Create a quick image editor for Spectacle.

@rkflx @huoni
I've added few more things, like multiple item selection/delete/move, bring selected items to front/back, different cursors for hover over items and resize, snap-to for creating items (hold ctrl), toggle selection (hold ctrl), preciser hit detection (we count now only hit on shape, if item has no file, the inner space is not accounted as item).

Apr 14 2018, 8:35 PM · VDG, Spectacle

Apr 3 2018

dporobic added a comment to T6321: [WISH] Create a quick image editor for Spectacle.

Yeap, that looks nice, that is the kind of control I was hopping to implement. I'll look later into implementing something like this (or the exact think) in KWidgetsAddons, when we get to the fine-tuning stuff.

Apr 3 2018, 6:20 AM · VDG, Spectacle

Mar 15 2018

dporobic added a comment to T6321: [WISH] Create a quick image editor for Spectacle.

Yeah, saving configuration and last screenshot option is saved by default though this can be disabled via settings. Same works in KImageAnnotator now, I'm using more or less the same approach.
The color grid works like: Load a predefined list of colors, after loaded, load last or default color for current tool, if the color doesn't exists in current grid, add the color to the grid. So basically all but the last selected custom color is cleared on startup. If you have selected one of the default colors, all custom colors are deleted after startup.

Mar 15 2018, 7:26 PM · VDG, Spectacle

Mar 14 2018

dporobic added a comment to T6321: [WISH] Create a quick image editor for Spectacle.

…now this also looks kinda neat. I guess that's because compared to your initial screenshot here the downwards pointing arrows are missing, making me wonder about usability for the user, though…

The initial screenshot is a QToolButton with menu. What I've added here is only a QToolButton that opens QColorDialog, which, in case we pick this approach, I would replace with a popup menu, that shows a grid with colors, similar to the one I have used in KSnip. We can show with or without arrow. KColorCombo is not very flexible as I can't set and custom icons so probably wouldn't use it. With the other option (one that looks and works like a combobox), I would make my own color combobox where I can set custom icons.

Mar 14 2018, 8:39 PM · VDG, Spectacle
dporobic added a comment to T6321: [WISH] Create a quick image editor for Spectacle.

And here the button version, which for me personally fits/looks best (image different icons for the two pickers and some nicer ordering):

Mar 14 2018, 7:03 PM · VDG, Spectacle
dporobic added a comment to T6321: [WISH] Create a quick image editor for Spectacle.

I would definitely go with two row tools when we put the properties stuff down there, I do not like the space there too.

Mar 14 2018, 6:34 PM · VDG, Spectacle
dporobic added a comment to T6321: [WISH] Create a quick image editor for Spectacle.

I've been playing around with the color picker, tried out KColorCombo and some custom stuff. Does this look anything useful? With the icon left from the Combobox it seems a bit too wide. Below for the size picker another option, custom adding icon into the combobox, something like they have in LibreOffice Draw, we could make the same for the color picker.

Mar 14 2018, 6:16 PM · VDG, Spectacle

Mar 12 2018

dporobic added a comment to T6321: [WISH] Create a quick image editor for Spectacle.

I agree that three color settings might be an overkill for simply annotating a screenshots but I think that we need two, at least for the text and numbering tool as @huoni explained.

Mar 12 2018, 7:27 PM · VDG, Spectacle

Mar 11 2018

dporobic added a comment to T6321: [WISH] Create a quick image editor for Spectacle.

How about something like this instead of a new UI for editing screenshots with Spectacle: https://github.com/lupoDharkael/flameshot/blob/master/img/appPreview/animatedUsage.gif

Mar 11 2018, 3:34 PM · VDG, Spectacle
dporobic added a comment to T6321: [WISH] Create a quick image editor for Spectacle.

Update:
I was not happy with the KColourPaint style so I went more in direction of LibreOffice Draw, I'm trying out not this approach, here is how it looks like:

Mar 11 2018, 1:06 PM · VDG, Spectacle

Mar 7 2018

dporobic added a comment to T6321: [WISH] Create a quick image editor for Spectacle.

Can we in Phabricator somehow track open tasks? I would like to have a list of stuff that is planned and will come eventually in future, we could use the to prioritize and track progress. Other folks would be able to see what is planned and what note and eventually add wishes. Something like sub-tasks. How do you handle stuff like that?

Mar 7 2018, 10:16 AM · VDG, Spectacle
dporobic added a comment to T6321: [WISH] Create a quick image editor for Spectacle.

Instead of PNGs, we can probably find some SVG icons in Breeze or try to request missing ones.

Agreed. Current icons don't adapt to dark themes :)

Mar 7 2018, 10:11 AM · VDG, Spectacle
dporobic added a comment to T6321: [WISH] Create a quick image editor for Spectacle.

@rkflx Thanks for the detailed feedback :)

Mar 7 2018, 9:52 AM · VDG, Spectacle

Feb 25 2018

dporobic added a comment to T6321: [WISH] Create a quick image editor for Spectacle.

I've made a prototype for the Image Annotator, nothing fancy, four annotation items, selection, resizing and deleting. I wanted to test how I could achieve the item resizing and I think that works fine now, so I will slowly turn that into a working application/widget.

Feb 25 2018, 6:44 PM · VDG, Spectacle

Feb 7 2018

dporobic added a comment to T6321: [WISH] Create a quick image editor for Spectacle.

Nice, I'll start work on this, hopefully before weekend. I believe we can quickly have some basic functionality for first thought.

Feb 7 2018, 12:22 PM · VDG, Spectacle
dporobic added a comment to T6321: [WISH] Create a quick image editor for Spectacle.

I came to the conclusion though, that this component/framework probably won't be so generic to be called "KImageEditor" but rather "KScreenshotEditor" or "KAnnotateImageEditor"

Feb 7 2018, 7:41 AM · VDG, Spectacle

Feb 5 2018

dporobic added a comment to T6321: [WISH] Create a quick image editor for Spectacle.

Assume we want to annotate something in Gwenview or Skanlite: Certainly we would not want to replace Gwenview's advanced image display component completely

Feb 5 2018, 9:49 AM · VDG, Spectacle

Feb 4 2018

dporobic added a comment to T6321: [WISH] Create a quick image editor for Spectacle.

I think I'm a fan of the annotation widget approach. Later on we could replace the preview window with the annotation widget.
Someone mentioned KParts earlier, I haven't worked with it yet but that could be something suitable as fart as I can tell from my quick googeling. Would be nice to have someone with experience with KParts to give kick start or at least point me in the right direction.

Feb 4 2018, 3:35 PM · VDG, Spectacle
dporobic added a comment to T6321: [WISH] Create a quick image editor for Spectacle.

Ok, that would go in direction of being an annotation "widget" that you could use basically anywhere, interesting idea.

Feb 4 2018, 2:53 PM · VDG, Spectacle
dporobic added a comment to T6321: [WISH] Create a quick image editor for Spectacle.

@rkflx
Ok, so we go for now with a separate window, it's not the perfect solution but it might be our best bet for now and we could change stuff in the future when we have some foundation.

Feb 4 2018, 2:17 PM · VDG, Spectacle
dporobic added a comment to T6321: [WISH] Create a quick image editor for Spectacle.

@rkflx Thank you for your detailed feedback!

Feb 4 2018, 11:32 AM · VDG, Spectacle
dporobic added a comment to T6321: [WISH] Create a quick image editor for Spectacle.

If no one is working on this task I would take it and see what I can do.

Feb 4 2018, 8:18 AM · VDG, Spectacle

Feb 13 2017

dporobic added a comment to D4483: Keyboard shortcuts for Uses in Code Browser.

Changed formatting as suggested. If it's ok now could you please commit the patch, I don't have commit rights?

Feb 13 2017, 8:07 AM · KDevelop

Feb 12 2017

dporobic added a comment to D4483: Keyboard shortcuts for Uses in Code Browser.

Changed formatting as suggested. If it's ok now could you please commit the patch, I don't have commit rights?

Feb 12 2017, 1:15 PM · KDevelop
dporobic updated the diff for D4483: Keyboard shortcuts for Uses in Code Browser.

More formatting and style cleanup as suggested by mwolff

Feb 12 2017, 1:13 PM · KDevelop

Feb 11 2017

dporobic added inline comments to D4483: Keyboard shortcuts for Uses in Code Browser.
Feb 11 2017, 7:32 PM · KDevelop
dporobic updated the diff for D4483: Keyboard shortcuts for Uses in Code Browser.

Moved must of the functionality to single free function in separate namespace. Some additional cleanup as suggested by mwolff

Feb 11 2017, 7:28 PM · KDevelop

Feb 7 2017

dporobic retitled D4483: Keyboard shortcuts for Uses in Code Browser from to Keyboard shortcuts for Uses in Code Browser.
Feb 7 2017, 6:29 PM · KDevelop

Feb 1 2017

dporobic added a comment to D4334: Pressing "Continue" starts "Debug" if program is not running.

Sure, damir_porobic(at)live(dot)com would be the address and name is Damir Porobic.

Feb 1 2017, 6:18 PM · KDevelop

Jan 31 2017

dporobic added a comment to D4334: Pressing "Continue" starts "Debug" if program is not running.
In D4334#81627, @mwolff wrote:

one minor nitpick, otherwise lgtm

do you have commit rights? if so, feel free to amend and push to master

Jan 31 2017, 4:02 PM · KDevelop
dporobic updated the diff for D4334: Pressing "Continue" starts "Debug" if program is not running.

Changed function name that changes the continue action properties from continueStartsDebug to setContinueStartsDebug

Jan 31 2017, 3:57 PM · KDevelop

Jan 30 2017

dporobic added a comment to D4334: Pressing "Continue" starts "Debug" if program is not running.
In D4334#81123, @mwolff wrote:

I am missing some things here, besides the nitpicks below:

The action's tooltip, and possibly even its icon, should now imo update depending on the state to indicate what action will be triggered when it is executed.

Can you implement that as well please?

Thanks

Jan 30 2017, 6:29 PM · KDevelop
dporobic updated the diff for D4334: Pressing "Continue" starts "Debug" if program is not running.

+ Added a function that changes the icon and text of the continue_debug action to look like launch_debug action depending on the debugger state.
+ Changed formatting as suggested by mwolff.

Jan 30 2017, 6:21 PM · KDevelop

Jan 29 2017

dporobic added reviewers for D4334: Pressing "Continue" starts "Debug" if program is not running: apol, kfunk.
Jan 29 2017, 1:50 PM · KDevelop
dporobic retitled D4334: Pressing "Continue" starts "Debug" if program is not running from to Pressing "Continue" starts "Debug" if program is not running.
Jan 29 2017, 1:49 PM · KDevelop

Jan 26 2017

dporobic added a comment to D4126: Add a "clear" button and related code for the OutputView.

https://bugs.kde.org/show_bug.cgi?id=361420

Jan 26 2017, 10:15 PM