- User Since
- Jan 26 2017, 10:32 AM (68 w, 6 d)
Mon, May 21
@rkflx do you have a CI that builds on every commit? xD
That was another refactoring, should be working again.
Thu, May 10
@rkflx the slow test build should be fixed now. The initial approach has build all the source for every source file, now we build the source as a library once and link it to every test.
Apr 22 2018
It's not obvious enough. You could have just changed the colours of those items to a lighter shade.
It's not the same, with this approach you see selected items that are hidden behind other items and the color could be any color of course.
Apr 20 2018
@huoni how about something like this for selected items:
Apr 17 2018
Thanks for the feedback :)
Apr 14 2018
I've added few more things, like multiple item selection/delete/move, bring selected items to front/back, different cursors for hover over items and resize, snap-to for creating items (hold ctrl), toggle selection (hold ctrl), preciser hit detection (we count now only hit on shape, if item has no file, the inner space is not accounted as item).
Apr 3 2018
Yeap, that looks nice, that is the kind of control I was hopping to implement. I'll look later into implementing something like this (or the exact think) in KWidgetsAddons, when we get to the fine-tuning stuff.
Mar 15 2018
Yeah, saving configuration and last screenshot option is saved by default though this can be disabled via settings. Same works in KImageAnnotator now, I'm using more or less the same approach.
The color grid works like: Load a predefined list of colors, after loaded, load last or default color for current tool, if the color doesn't exists in current grid, add the color to the grid. So basically all but the last selected custom color is cleared on startup. If you have selected one of the default colors, all custom colors are deleted after startup.
Mar 14 2018
…now this also looks kinda neat. I guess that's because compared to your initial screenshot here the downwards pointing arrows are missing, making me wonder about usability for the user, though…
The initial screenshot is a QToolButton with menu. What I've added here is only a QToolButton that opens QColorDialog, which, in case we pick this approach, I would replace with a popup menu, that shows a grid with colors, similar to the one I have used in KSnip. We can show with or without arrow. KColorCombo is not very flexible as I can't set and custom icons so probably wouldn't use it. With the other option (one that looks and works like a combobox), I would make my own color combobox where I can set custom icons.
And here the button version, which for me personally fits/looks best (image different icons for the two pickers and some nicer ordering):
I would definitely go with two row tools when we put the properties stuff down there, I do not like the space there too.
I've been playing around with the color picker, tried out KColorCombo and some custom stuff. Does this look anything useful? With the icon left from the Combobox it seems a bit too wide. Below for the size picker another option, custom adding icon into the combobox, something like they have in LibreOffice Draw, we could make the same for the color picker.
Mar 12 2018
I agree that three color settings might be an overkill for simply annotating a screenshots but I think that we need two, at least for the text and numbering tool as @huoni explained.
Mar 11 2018
How about something like this instead of a new UI for editing screenshots with Spectacle: https://github.com/lupoDharkael/flameshot/blob/master/img/appPreview/animatedUsage.gif
I was not happy with the KColourPaint style so I went more in direction of LibreOffice Draw, I'm trying out not this approach, here is how it looks like:
Mar 7 2018
Can we in Phabricator somehow track open tasks? I would like to have a list of stuff that is planned and will come eventually in future, we could use the to prioritize and track progress. Other folks would be able to see what is planned and what note and eventually add wishes. Something like sub-tasks. How do you handle stuff like that?
Instead of PNGs, we can probably find some SVG icons in Breeze or try to request missing ones.
Agreed. Current icons don't adapt to dark themes :)
@rkflx Thanks for the detailed feedback :)
Feb 25 2018
I've made a prototype for the Image Annotator, nothing fancy, four annotation items, selection, resizing and deleting. I wanted to test how I could achieve the item resizing and I think that works fine now, so I will slowly turn that into a working application/widget.
Feb 7 2018
Nice, I'll start work on this, hopefully before weekend. I believe we can quickly have some basic functionality for first thought.
I came to the conclusion though, that this component/framework probably won't be so generic to be called "KImageEditor" but rather "KScreenshotEditor" or "KAnnotateImageEditor"
Feb 5 2018
Assume we want to annotate something in Gwenview or Skanlite: Certainly we would not want to replace Gwenview's advanced image display component completely
Feb 4 2018
I think I'm a fan of the annotation widget approach. Later on we could replace the preview window with the annotation widget.
Someone mentioned KParts earlier, I haven't worked with it yet but that could be something suitable as fart as I can tell from my quick googeling. Would be nice to have someone with experience with KParts to give kick start or at least point me in the right direction.
Ok, that would go in direction of being an annotation "widget" that you could use basically anywhere, interesting idea.
Ok, so we go for now with a separate window, it's not the perfect solution but it might be our best bet for now and we could change stuff in the future when we have some foundation.
@rkflx Thank you for your detailed feedback!
If no one is working on this task I would take it and see what I can do.
Feb 13 2017
Feb 12 2017
Changed formatting as suggested. If it's ok now could you please commit the patch, I don't have commit rights?
More formatting and style cleanup as suggested by mwolff
Feb 11 2017
Moved must of the functionality to single free function in separate namespace. Some additional cleanup as suggested by mwolff
Feb 7 2017
Feb 1 2017
Sure, damir_porobic(at)live(dot)com would be the address and name is Damir Porobic.
Jan 31 2017
Changed function name that changes the continue action properties from continueStartsDebug to setContinueStartsDebug
Jan 30 2017
+ Added a function that changes the icon and text of the continue_debug action to look like launch_debug action depending on the debugger state.
+ Changed formatting as suggested by mwolff.