Instead of opening an additional dialog, allow selection and deselection
of visible properties directly in the widget.
CCBUG: 389571
Details
Details
- Reviewers
ngraham astippich elvisangelaccio - Group Reviewers
Baloo Dolphin Frameworks - Commits
- R824:c36d6b26eb3f: [FileMetaDataWidget] Allow inline configuration of visible properties
Diff Detail
Diff Detail
- Repository
- R824 Baloo Widgets
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Hmm, it seems you need to rebase this patch:
$ arc patch D20524 INFO Base commit is not in local repository; trying to fetch. Created and checked out branch arcpatch-D20524. This diff is against commit b26a3680b04cb9877721d693eb79ccb321fe40aa, but the commit is nowhere in the working copy. Try to apply it against the current working copy state? (49e778edf7bd70842879cc338fb85c1a178ecf7f) [Y/n] Y
( I tried to apply it on current master)
| src/filemetadatawidget.h | ||
|---|---|---|
| 47–49 | Sure, just wanted to see if the (UI) design itself is deemed appropriate. | |
Comment Actions
Worked for me:
INFO Base commit is not in local repository; trying to fetch.
Created and checked out branch arcpatch-D20524.
This diff is against commit b26a3680b04cb9877721d693eb79ccb321fe40aa, but
the commit is nowhere in the working copy. Try to apply it against the
current working copy state? (5f2ab5c62dd56e5a1dae468355c9e72d84d94398)
[Y/n] y
Checking patch src/filemetadatawidget.h...
Checking patch src/filemetadatawidget.cpp...
Applied patch src/filemetadatawidget.h cleanly.
Applied patch src/filemetadatawidget.cpp cleanly.
OKAY Successfully committed patch.Comment Actions
I have some debug output lower in the commit stack, which is likely responsible for the SHA hash mismatch, although it should apply with just the warning.
Note, D20523 was commited in the mean time.
| src/filemetadatawidget.h | ||
|---|---|---|
| 93 | Should be @since 19.08.0 (baloo-widgets follows the KDE Applications versioning) | |