Redesign config pages
ClosedPublic

Authored by nicolasfella on Mar 10 2019, 2:09 AM.

Details

Reviewers
apol
ngraham
Group Reviewers
VDG
Commits
R495:1eef04076c31: Redesign config pages
Summary

Redesign the KDE Connect and Bluetooth pages as well as some adjustments to all pages

Before:

After:


Bluetooth is basically identical

Diff Detail

Repository
R495 Purpose Library
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
nicolasfella created this revision.Mar 10 2019, 2:09 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptMar 10 2019, 2:09 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
nicolasfella requested review of this revision.Mar 10 2019, 2:09 AM
nicolasfella edited the summary of this revision. (Show Details)Mar 10 2019, 2:13 AM
nicolasfella edited the summary of this revision. (Show Details)
ngraham requested changes to this revision.Mar 10 2019, 5:09 AM

Better! Could we get a frame and a white background behind this list?

This revision now requires changes to proceed.Mar 10 2019, 5:09 AM

Less technical note: I think that the commit message should not really about KDE Connect, as the change is reflected on all Purpose's users.

abetts added a subscriber: abetts.Mar 10 2019, 6:42 PM

Could there be a checkmark box or some way to indicate what selection has been made?

apol added a comment.Mar 11 2019, 12:13 AM

This adds a dependency to Kirigami. We are already tier2 so that's okay, but reflect it on CMake at least.

src/plugins/kdeconnect/kdeconnectplugin_config.qml
29

Use icon.name.

  • Implement Nates suggestion
nicolasfella added inline comments.Fri, Jun 21, 4:26 PM
src/plugins/kdeconnect/kdeconnectplugin_config.qml
29

iconName comes from the DeviceModel. We just expose the name, not the actual ico from KDE Connect

  • Implement Nates suggestion
  • Look for Kirigami
nicolasfella retitled this revision from Redesign KDE Connect and bluetooth config pages to Redesign config pages.Fri, Jun 21, 4:36 PM
nicolasfella edited the summary of this revision. (Show Details)Fri, Jun 21, 4:41 PM
ngraham accepted this revision.Fri, Jun 21, 4:45 PM

Super better! Code looks perfect.

This revision is now accepted and ready to land.Fri, Jun 21, 4:45 PM
apol accepted this revision.Fri, Jun 21, 4:52 PM
This revision was automatically updated to reflect the committed changes.
trmdi added a subscriber: trmdi.Fri, Jun 21, 5:09 PM

Does this window have too much empty space? Can it have less?

  • I guess we wouldn't have too many devices in most of the cases.
  • The device name is not often too long.

So can the default window size be reduced a bit? We wouldn't have to move the mouse too far from the chosen device to the Ok button?

GB_2 added a subscriber: GB_2.Fri, Jun 21, 5:24 PM

It would be great if you also improved the JobDialog buttons:

  • put them on the right
  • give them icons

Does this window have too much empty space? Can it have less?

  • I guess we wouldn't have too many devices in most of the cases.
  • The device name is not often too long. So can the default window size be reduced a bit? We wouldn't have to move the mouse too far from the chosen device to the Ok button?
In D19646#483593, @GB_2 wrote:

It would be great if you also improved the JobDialog buttons:

  • put them on the right
  • give them icons

+1 on both

In D19646#483593, @GB_2 wrote:

It would be great if you also improved the JobDialog buttons:

  • put them on the right
  • give them icons

Done with D22055