This patch mostly change the CSS to look more similar to the one from
kde.org/kontact.kde.org/...
The files common/en/{top-left.jpg,top-right.jpg,kde_logo_bg.png}
are now deprecated and will be removed in KF6.
Screenshots:
yurchor | |
ltoscano |
VDG | |
Documentation |
This patch mostly change the CSS to look more similar to the one from
kde.org/kontact.kde.org/...
The files common/en/{top-left.jpg,top-right.jpg,kde_logo_bg.png}
are now deprecated and will be removed in KF6.
Screenshots:
Tested with not regenerated documentation and regenerated documentation
No Linters Available |
No Unit Test Coverage |
Buildable 9347 | |
Build 9365: arc lint + arc unit |
I only had a png version in my hard drive, but if it's a problem I can convert the png in a jpg.
I tried this first but khtml didn't look like it support svg.
Add breeze like style for note/info/warning/tip admonitions and make image responsive
The logo is just 2 colors, and the PNG is smaller than the JPEG, without introducing artifacts. I would definitely prefer a PNG here.
Is it intentional the PNG is 129x129 while the JPEG is 128x128?
Also, the JPEG shold be removed.
I have no idea why 129x129. I used convert to convert the svg to png, just like I did with the jpg. But I will investigate this issue
Also, the JPEG shold be removed.
I'm not sure, but I think this will be a problem with some documentations where the html wasn't regenerated, because the html wasn't regenerated the image element will link to a deadlink.
The new PNG is fuzzy, thats probably the reason it does not compress well.
Try exporting it with inkscape, and check if the vertical/horizontal edges are pixel grid aligned.
On the graphical side I'm not the most qualified to talk :)
Apart from the VDG, I'm sure that @yurchor can give some hints, as he manages the templates used to generate the PDFs.
From the technical point of view, I wouldn't remove any of the exiting files right now, at least not until KF6. I'd suggest using new names, just to avoid the possible confusion between the old top-kde.jpg and the new top-kde.png.
@rooty The font can be changed in the khelpcenter settings. But it's strange that it doesn't use Plasma settings per default.
Can you please not overwrite top-kde.jpg too, or at least use the same size? Because the change of size may be a problem for existing users (if any, but I consider those files as part of the public interface of KDocTools
They use the old link for the image, also the jpg version instead of the png. I tested with new page and old page and the result is visually the same.
Yes the link to the css didn't change, only the content. So even the old page links to the new CSS.
In any case, please change the commit message. When this is committed and rechecked in one year from now, the aspect of the linked website may not be relevant anymore and the images are not visible when you run git log.
Please describe what the change is about. https://chris.beams.io/posts/git-commit/
Ok, so let's back one minute, and maybe it was the case in the original review, despite what myself and other people suggested, what if:
This should ensure no unexpected changes if any user expect the image to be that size, and both newly-generated pages and the old ones will have the same aspect.
Sorry if it was the case in the first review.
The point about the commit message is still valid.
common/en/kde-docs.css | ||
---|---|---|
252 ↗ | (On Diff #53367) | Seems there is no such CSS property font-height? Was this meant to be e.g. font-size or line-height? |