Differential D19472

[Task Manager] Make sure "Alternatives..." context menu item is always available
ClosedPublic
Actions

Authored by ngraham on Mar 2 2019, 1:30 PM.

Details

Reviewers
hein
davidedmundson
rooty
Group Reviewers
Plasma
Commits
R119:fd7b359f8461: [Task Manager] Make sure "Alternatives..." context menu item is always available
Summary

Currently, the Task Manager does not show the Alternatives... item in the context
menu for tasks, so it's inaccessible when the Task Manager is full. This patch fixes
that.

BUG: 404969
FIXED-IN: 5.15.3

Test Plan
  • Menu item is visible in the context menu for individual tasks when widgets are unlocked
  • Menu item is hidden when widgets are locked
  • Menu item works, and shows the Alternatives panel when clicked
  • No duplication in context menu for an empty area of the Task Manager

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ngraham created this revision.Mar 2 2019, 1:30 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 2 2019, 1:30 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Mar 2 2019, 1:30 PM
ngraham edited the test plan for this revision. (Show Details)Mar 2 2019, 1:31 PM
davidedmundson accepted this revision.Mar 2 2019, 1:55 PM
This revision is now accepted and ready to land.Mar 2 2019, 1:55 PM
rooty accepted this revision.Mar 2 2019, 2:01 PM
rooty added a subscriber: rooty.

You have no idea how much of a headache not having this option has been.... huge +1

Closed by commit R119:fd7b359f8461: [Task Manager] Make sure "Alternatives..." context menu item is always available (authored by ngraham). · Explain WhyMar 2 2019, 2:05 PM
This revision was automatically updated to reflect the committed changes.
broulik added a subscriber: broulik.Mar 8 2019, 9:53 AM

This suffers from the same bug as the action in the D17410. The action doesn't show up unless the real applet context menu was opened once.

abetts added a subscriber: abetts.Mar 8 2019, 3:44 PM

Can it be more descriptive? Using two words might help it be extra clear what the button is about.

ngraham added a comment.Mar 9 2019, 12:31 AM
In D19472#427046, @broulik wrote:

This suffers from the same bug as the action in the D17410. The action doesn't show up unless the real applet context menu was opened once.

So I see. :(

I guess we really gotta figure out how to call plasmoid.contextualActionsAboutToShow(); before a different context menu appears.

GB_2 added a subscriber: GB_2.Mar 9 2019, 5:42 PM
In D19472#427613, @ngraham wrote:
In D19472#427046, @broulik wrote:

This suffers from the same bug as the action in the D17410. The action doesn't show up unless the real applet context menu was opened once.

So I see. :(

I guess we really gotta figure out how to call plasmoid.contextualActionsAboutToShow(); before a different context menu appears.

Yeah, I think @davidedmundson has it on his TODO list, I asked him at a monday meeting.

Revision Contents
Changeset List

Diff 52983

View Options

applets/taskmanager/package/contents/ui/ContextMenu.qml

Loading...