Differential D19445

Handle variant list in formatting functions
ClosedPublic
Actions

Authored by astippich on Mar 1 2019, 4:14 PM.

Details

Reviewers
ngraham
bruns
Commits
R286:ffdee4011145: Handle variant list in formatting functions
Summary

Improve the formatting function of
KFileMetaData such that it will also handle
QVariantLists for each property, to make it more
robust

Test Plan

tests pass

Diff Detail

Repository
R286 KFileMetaData
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
astippich created this revision.Mar 1 2019, 4:14 PM
Restricted Application added projects: Frameworks, Baloo. · View Herald TranscriptMar 1 2019, 4:14 PM
Restricted Application added subscribers: Baloo, kde-frameworks-devel. · View Herald Transcript
astippich requested review of this revision.Mar 1 2019, 4:14 PM
bruns requested changes to this revision.Mar 22 2019, 10:17 PM
bruns added inline comments.
src/propertyinfo.cpp
645

Don't reinvent Qt functionality:
https://doc.qt.io/qt-5/qlocale.html#createSeparatedList

This revision now requires changes to proceed.Mar 22 2019, 10:17 PM
astippich updated this revision to Diff 54651.Mar 24 2019, 10:51 AM
  • code style
astippich marked an inline comment as done.Mar 24 2019, 10:53 AM
astippich added inline comments.
src/propertyinfo.cpp
645

see D20013

astippich updated this revision to Diff 54956.Mar 27 2019, 7:28 PM
astippich marked an inline comment as done.
  • implement feedback
astippich added a comment.Mar 31 2019, 11:39 AM

ping. This will be beneficial for handling lists regardless of the discussion in D19087

astippich updated this revision to Diff 55326.Apr 3 2019, 6:13 AM
  • rebase on master
apol added a subscriber: apol.Apr 9 2019, 8:43 PM
apol added inline comments.
src/propertyinfo.cpp
650

displayList << d->formatAsString(entry);

astippich updated this revision to Diff 55926.Apr 10 2019, 5:28 PM
  • remove unrequired parenthesis
astippich marked an inline comment as done.Apr 10 2019, 5:29 PM
apol added a comment.Apr 11 2019, 11:36 AM

Patch looks good to me, @bruns note that you still have it set as "changes required".

bruns accepted this revision.Apr 14 2019, 1:56 PM
bruns added inline comments.
autotests/propertyinfotest.cpp
125

That one looks strange :-P

This revision is now accepted and ready to land.Apr 14 2019, 1:56 PM
Closed by commit R286:ffdee4011145: Handle variant list in formatting functions (authored by astippich). · Explain WhyApr 16 2019, 5:46 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mautotests/propertyinfotest.cpp (6 lines)
Msrc/propertyinfo.cpp (15 lines)

Diff 56384

View Options

autotests/propertyinfotest.cpp

Loading...
View Options

src/propertyinfo.cpp

Loading...