Differential D20013

Use Qt function for string list formatting
ClosedPublic
Actions

Authored by astippich on Mar 24 2019, 10:52 AM.

Details

Reviewers
bruns
Commits
R286:3a83a49a4350: Use Qt function for string list formatting
Summary

Reuse existing Qt function to convert string
lists into string

Diff Detail

Repository
R286 KFileMetaData
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
astippich created this revision.Mar 24 2019, 10:52 AM
Restricted Application added projects: Frameworks, Baloo. · View Herald TranscriptMar 24 2019, 10:52 AM
Restricted Application added subscribers: Baloo, kde-frameworks-devel. · View Herald Transcript
astippich requested review of this revision.Mar 24 2019, 10:52 AM
bruns added a comment.Mar 25 2019, 12:41 PM

I think this should go in before D19445.

src/propertyinfo.cpp
635 ↗(On Diff #54653)

unnecessary indirection

bruns requested changes to this revision.Mar 25 2019, 12:42 PM
This revision now requires changes to proceed.Mar 25 2019, 12:42 PM
astippich updated this revision to Diff 54951.Mar 27 2019, 7:18 PM
  • rebase directly on master
astippich removed a dependency: D19445: Handle variant list in formatting functions.Mar 27 2019, 7:18 PM

Is removing a string allowed during string freeze?

bruns accepted this revision.Mar 27 2019, 7:22 PM

Worst that can happen is a translators just happens to translate it now, and then it is just some unnecessary, but trivial work done without need.

This revision is now accepted and ready to land.Mar 27 2019, 7:23 PM
Closed by commit R286:3a83a49a4350: Use Qt function for string list formatting (authored by astippich). · Explain WhyMar 27 2019, 7:26 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mautotests/propertyinfotest.cpp (4 lines)
Msrc/formatstrings.cpp (2 lines)

Diff 54954

View Options

autotests/propertyinfotest.cpp

Loading...
View Options

src/formatstrings.cpp

Loading...