Change properties attributes for consistency
ClosedPublic
Actions

Authored by astippich on Apr 14 2019, 9:18 AM.

Details

Reviewers

bruns

Commits

Summary

Move all the handling of (string-)lists into
the member function, and mark the attributes
consistently.

Repository

R286 KFileMetaData

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added subscribers: Baloo, kde-frameworks-devel. · View Herald Transcript

astippich requested review of this revision.Apr 14 2019, 9:18 AM

10 lines removed, 1 added, 10 times more functionality 👍

This revision is now accepted and ready to land.Apr 14 2019, 1:54 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			autotests/taglibextractortest.cpp (8 lines)
M			src/formatstrings.cpp (5 lines)
M			src/formatstrings_p.h (2 lines)
M			src/propertyinfo.cpp (38 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	56173	321e693		Apr 14 2019, 9:18 AM	★	★
Diff 2	56385	ffdee40	R286:4808263e41bfd4285536df61b3cab25f54cf037f	Apr 16 2019, 5:46 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
25a0254de5ab	2fde1115b884	612a8040d7ca	Alexander Stippich	fix	Apr 14 2019, 9:16 AM
612a8040d7ca	97765c7f2e8e	8c1351e6b19b	Alexander Stippich	remove string function	Apr 9 2019, 5:50 PM
8c1351e6b19b	a09738e3133f	321e693846d0	Alexander Stippich	Change properties attributes for consistency	Mar 23 2019, 11:02 AM

Status	Author	Revision
Closed	astippich	D20528 Change properties attributes for consistency
Closed	astippich	D19445 Handle variant list in formatting functions
Closed	astippich	D20012 Fix number localization for properties