Correct code style of Client fullscreen control
Needs ReviewPublic

Authored by romangg on Thu, Jan 10, 12:23 PM.


Group Reviewers

As a preperational step for future changes obey the code
styling guide in Client fullscreen functionality.

No functional changes.

Test Plan

Manually, autotests pass.

Diff Detail

R108 KWin
Lint OK
No Unit Test Coverage
Build Status
Buildable 6905
Build 6923: arc lint + arc unit
romangg created this revision.Thu, Jan 10, 12:23 PM
Restricted Application added a project: KWin. · View Herald TranscriptThu, Jan 10, 12:23 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
romangg requested review of this revision.Thu, Jan 10, 12:23 PM

I'm not sure about this change, it changes git history, on the other hand it makes things more consistent. Maybe @graesslin can weigh in here.

Well I always kept such old code as it was. I faced this problem a lot during the port to Wayland and introducing the AbstractClient. In the end I decided to not change anything that's in Client or Toplevel, but AbstractClient introduces the more "modern" approach.

We just have to accept that KWin is an old application with several generations of developers. We can be sure that the next generation will also think that our naming was inconsistent and stupid. Personally I think it's not worth to try to adjust to the current "modern".