Rework ShellClient fullscreen control
Needs ReviewPublic

Authored by romangg on Wed, Jan 9, 8:08 PM.

Details

Reviewers
None
Group Reviewers
KWin
Summary

The ShellClient::setFullScreen method was a direct copy of the Client
version.

Straighten out the function logic now and align with modern coding style.

In short we check:

  1. what the manual override window rule wants,
  2. if there is a change at all with this,
  3. if such a change is possible.

And do:

  1. (un-)set the fullscreen,
  2. emit the changed signal.
Test Plan

Manually, autotests pass.

Diff Detail

Repository
R108 KWin
Branch
shellClientFullScreenable
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 6871
Build 6889: arc lint + arc unit
romangg created this revision.Wed, Jan 9, 8:08 PM
Restricted Application added a project: KWin. · View Herald TranscriptWed, Jan 9, 8:08 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
romangg requested review of this revision.Wed, Jan 9, 8:08 PM
zzag added a subscriber: zzag.Wed, Jan 9, 8:28 PM

Please capitalize "screen" in "fullscreen".

shell_client.h
88–90

Unrelated change.

In D18132#390113, @zzag wrote:

Please capitalize "screen" in "fullscreen".

I'm thinking about going the other way. Changing every occurrence of FullScreen to Fullscreen. Wikipedia, the Wayland docs and xdg-shell stable all write the word together. So camel case S is not in order.

zzag added a comment.Thu, Jan 10, 12:33 PM

I'm thinking about going the other way. Changing every occurrence of FullScreen to Fullscreen. Wikipedia, the Wayland docs and xdg-shell stable all write the word together. So camel case S is not in order.

Argh, consistency will be messed up. Currently, capitalized "screen" is more popular in KWin, though in KWayland "screen" has lowercase.