Most parts of this function are only relevant for X clients, in particular
the "fullscreen hack". Therefore split up the function into the AbstractClient
subclasses.
Details
Details
- Reviewers
zzag - Group Reviewers
KWin - Maniphest Tasks
- T11098: Replace Screens class
- Commits
- R108:787c22ec4c1e: Split up fullscreen able check into AbstractClient subclasses
Manually and autotests still pass.
Diff Detail
Diff Detail
- Repository
- R108 KWin
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
| client.cpp | ||
|---|---|---|
| 606–612 | We lose this path in ShellClient::isFullScreenable. Is there a reason for thta? | |
| client.cpp | ||
|---|---|---|
| 606–612 | Wayland native clients can't dictate the compositor if fullscreen is possible or not. so we don't need to check if their geometry is restricted. At least the call to AbstractClient::sizeForClientSize in the case of ShellClient in the current version on master would imply this. | |
| client.cpp | ||
|---|---|---|
| 606–612 | As far as I know, it depends on compositor's policies, e.g. if max size was set for a xdg-toplevel, then compositor can disallow the fullscreen state, though this is probably unrelated. I just wanted to make sure you did this on purpose. | |
| shell_client.cpp | ||
| 938 | Should popups be fullscreen-able? | |
| shell_client.cpp | ||
|---|---|---|
| 938 | Wouldn't say so. | |
| shell_client.cpp | ||
|---|---|---|
| 938 | Then we probably have to check isPopupWindow. | |