As a preperational step for future changes obey the code
styling guide in Client fullscreen functionality.
No functional changes.
davidedmundson |
KWin |
As a preperational step for future changes obey the code
styling guide in Client fullscreen functionality.
No functional changes.
Manually, autotests pass.
Automatic diff as part of commit; lint not applicable. |
Automatic diff as part of commit; unit tests not applicable. |
I'm not sure about this change, it changes git history, on the other hand it makes things more consistent. Maybe @graesslin can weigh in here.
Well I always kept such old code as it was. I faced this problem a lot during the port to Wayland and introducing the AbstractClient. In the end I decided to not change anything that's in Client or Toplevel, but AbstractClient introduces the more "modern" approach.
We just have to accept that KWin is an old application with several generations of developers. We can be sure that the next generation will also think that our naming was inconsistent and stupid. Personally I think it's not worth to try to adjust to the current "modern".
Personally I think it's not worth to try to adjust to the current "modern".
Yes, it sounds reasonable.
There will be larger changes to legacy code in the near future as of T11098. That means git history will be fucked up anyway. Better clear house beforehand.
I plan on discussing the future development pace and direction of KWin at Plasma sprint next week with my fellow KWin devs. Nevertheless I want to push the patches of this series before that in order to keep progressing with the parent Screens task.