- Group Reviewers
- R120:87aa1884dfe1: [Login and lock screens] Do not use light font styles for the sddm clock
Worst case scenario (legibility extremely poor):
Before and after the patch:
This only hits the lock screen. The login screen has its own clock component, so the fix needs to be made there too. It's in sddm-theme: https://cgit.kde.org/plasma-workspace.git/tree/sddm-theme/Clock.qml#n48
The login screen has its own clock component,
Removing that so there's only 1 would also work. It's all self contained so they can be shared and installed in components already.
As for this change, +1 from me, anything that hardcodes font style is normally wrong - but it's purely visual so VDG can have final input on that.
You need to fix your git authorship information:
commit 7fec5a19e16f2868e11486ad6b9739bb69cf214e (HEAD -> arcpatch-D17916) Author: Rooty <Rooty> Date: Wed Jan 2 08:09:25 2019 -0700
That will be rejected by a commit hookscript if I try to land the patch. The Author field needs a first name and a last name and an email address in the pointy brackets.