[Login and lock screens] Do not use light font styles for the sddm clock
ClosedPublic

Authored by rooty on Jan 2 2019, 1:00 PM.

Details

Summary

This patch removes the line of code that required that the lock screen use a light font style.
This patch is also closely related to the fixes in D17905, D17906 and D17907.

Test Plan

Worst case scenario (legibility extremely poor):

Before and after the patch:

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
rooty created this revision.Jan 2 2019, 1:00 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJan 2 2019, 1:00 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
rooty requested review of this revision.Jan 2 2019, 1:00 PM
ngraham requested changes to this revision.Jan 2 2019, 2:38 PM

This only hits the lock screen. The login screen has its own clock component, so the fix needs to be made there too. It's in sddm-theme: https://cgit.kde.org/plasma-workspace.git/tree/sddm-theme/Clock.qml#n48

This revision now requires changes to proceed.Jan 2 2019, 2:38 PM
rooty updated this revision to Diff 48534.Jan 2 2019, 2:41 PM

Apply patch to login theme as well

ngraham accepted this revision.Jan 2 2019, 2:43 PM

Much better, thanks.

This revision is now accepted and ready to land.Jan 2 2019, 2:43 PM

The login screen has its own clock component,

Removing that so there's only 1 would also work. It's all self contained so they can be shared and installed in components already.


As for this change, +1 from me, anything that hardcodes font style is normally wrong - but it's purely visual so VDG can have final input on that.

The files' content is currently identical so would this just be a matter of removing the one in sddm-theme?

The files' content is currently identical so would this just be a matter of removing the one in sddm-theme?

It looks like it

Great, let's do that in another patch after this.

You need to fix your git authorship information:

commit 7fec5a19e16f2868e11486ad6b9739bb69cf214e (HEAD -> arcpatch-D17916)
Author: Rooty <Rooty>
Date:   Wed Jan 2 08:09:25 2019 -0700

That will be rejected by a commit hookscript if I try to land the patch. The Author field needs a first name and a last name and an email address in the pointy brackets.

Found the correct name and email address in https://phabricator.kde.org/D16937#362252. @rooty for future reference you'll need to fix this in the ~/.gitconfig file on your local machine.

Closed by commit R120:87aa1884dfe1: [Login and lock screens] Do not use light font styles for the sddm clock (authored by Krešimir Čohar <kcohar@gmail.com>, committed by ngraham). · Explain WhyJan 2 2019, 3:28 PM
This revision was automatically updated to reflect the committed changes.