[KWidgetsAddons] Do not use light font styles for headings (3/3)
ClosedPublic

Authored by rooty on Jan 1 2019, 9:53 PM.

Details

Summary

This patch brings back regular font styles for headings to KTitleWidget for the sake of consistency with QML and Kirigami, where they were also reintroduced in favor of better legibility.

CCBUG: 402730

FIXED-IN: 5.54

Test Plan

Before:


After:

Diff Detail

Repository
R236 KWidgetsAddons
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
rooty created this revision.Jan 1 2019, 9:53 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptJan 1 2019, 9:53 PM
rooty requested review of this revision.Jan 1 2019, 9:53 PM
rooty edited the summary of this revision. (Show Details)Jan 1 2019, 9:56 PM
rooty retitled this revision from [frameworks] Do not use light font styles for headings (3/3) to [KWidgetsAddons] Do not use light font styles for headings (3/3).Jan 1 2019, 10:01 PM
rooty edited reviewers, added: Frameworks; removed: kde-frameworks-devel.
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald TranscriptJan 1 2019, 10:01 PM
rooty edited reviewers, added: VDG, Plasma; removed: cfeck.Jan 1 2019, 10:02 PM
rooty edited the summary of this revision. (Show Details)Jan 1 2019, 10:22 PM
rooty edited the summary of this revision. (Show Details)
rooty edited the test plan for this revision. (Show Details)
filipf added a subscriber: filipf.Jan 1 2019, 10:30 PM
rooty edited the summary of this revision. (Show Details)Jan 1 2019, 11:02 PM
ngraham accepted this revision.Jan 1 2019, 11:08 PM

Strongly approve for all the reasons given in https://bugs.kde.org/show_bug.cgi?id=402730.

Let's wait a bit though to make sure the Plasma developers have a chance to weigh in.

This revision is now accepted and ready to land.Jan 1 2019, 11:08 PM
cfeck added a subscriber: cfeck.Jan 1 2019, 11:57 PM
cfeck added inline comments.
src/ktitlewidget.cpp
241–242

Remove empty line before final }

rooty updated this revision to Diff 48502.EditedJan 2 2019, 12:00 AM

Remove empty line (formerly line 242)

Closed by commit R236:dc901a1f0b5f: [KWidgetsAddons] Do not use light font styles for headings (3/3) (authored by Krešimir Čohar <kcohar@gmail.com>, committed by ngraham). · Explain WhyJan 10 2019, 4:26 PM
This revision was automatically updated to reflect the committed changes.

BTW you still need to correct your ~/.gitconfig file to have your real name and email address. :)