Differential D17905

[frameworks] Do not use light font styles for headings (1/3)
ClosedPublic
Actions

Authored by filipf on Jan 1 2019, 9:49 PM.

Details

Reviewers
ngraham
Group Reviewers
Plasma
VDG
Frameworks
Commits
R242:fdc912468785: [frameworks] Do not use light font styles for headings (1/3)
Summary

This patch turns off light font styles for some headings because they cause visual and legibility issues, as explained in the respective bug report.

BUG: 402730

FIXED-IN: 5.54

Test Plan

Worst case scenario testing - font does not have a "light" variant and falls back to using a thinner one such as "hairline"

Before:

After:

Plasma defaults testing

Before:

After:

Diff Detail

Repository
R242 Plasma Framework (Library)
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
filipf created this revision.Jan 1 2019, 9:49 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptJan 1 2019, 9:49 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
filipf requested review of this revision.Jan 1 2019, 9:49 PM
filipf edited the summary of this revision. (Show Details)Jan 1 2019, 9:54 PM
filipf edited the test plan for this revision. (Show Details)
filipf added reviewers: ngraham, Plasma, VDG.
filipf retitled this revision from [frameworks] Don't use light font styles for headings (1/3) to [frameworks] Do not use light font styles for headings (1/3).Jan 1 2019, 11:02 PM
ngraham accepted this revision.Jan 1 2019, 11:08 PM

Strongly approve for all the reasons given in https://bugs.kde.org/show_bug.cgi?id=402730.

Let's wait a bit though to make sure the Plasma developers have a chance to weigh in.

This revision is now accepted and ready to land.Jan 1 2019, 11:08 PM
filipf edited the test plan for this revision. (Show Details)Jan 2 2019, 1:20 PM
filipf updated this revision to Diff 48579.EditedJan 2 2019, 11:04 PM

Remove another case of the Font.Light value being set

abetts added a subscriber: abetts.Jan 3 2019, 3:57 PM

I don't have a problem with the font as much as I have a problem with the spacing for the title labels. They seem to be super close to checkboxes, other labels and controls. There should be a clear separation. Adding a heavier font to the title label helps a lot but because of its weight and the closeness with the rest of the elements, it seems crammed.

Here are some good spacing examples for title labels

https://dribbble.com/shots/5774759-Photo-Album-Application

https://dribbble.com/shots/5779939-Qwick-Platform-Sneak-Peek

https://dribbble.com/shots/5774973-Chris-Jon-Podcast

And some good typographical advise

https://medium.com/@lukejones/3-typography-tips-for-a-more-comfortable-read-fed478affa8d

ngraham added a comment.Jan 3 2019, 7:21 PM
In D17905#385834, @abetts wrote:

I don't have a problem with the font as much as I have a problem with the spacing for the title labels. They seem to be super close to checkboxes, other labels and controls. There should be a clear separation. Adding a heavier font to the title label helps a lot but because of its weight and the closeness with the rest of the elements, it seems crammed.

Let's improve the spacings in another patch. :)

Closed by commit R242:fdc912468785: [frameworks] Do not use light font styles for headings (1/3) (authored by filipf, committed by ngraham). · Explain WhyJan 10 2019, 4:14 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 49167

View Options

src/declarativeimports/plasmaextracomponents/qml/Heading.qml

Loading...
View Options

src/declarativeimports/plasmaextracomponents/qml/Title.qml

Loading...