New tabbar implementation (accidentally?) added small margin between
terminal and tabbar's bottom separating line. This patch removes the
margin.
Comparison:
Depends on D17605
Details
Details
- Reviewers
tcanabrava ndavis hindenburg - Group Reviewers
Konsole VDG - Commits
- R319:db932cc04947: Restore previous tabbar look
Tested with default style and custom stylesheet
Diff Detail
Diff Detail
- Repository
- R319 Konsole
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
What would be the result if the cás was replaced by serDocumentMode(true); ?
Em sáb, 15 de dez de 2018 às 18:23, Mariusz Glebocki <
noreply@phabricator.kde.org> escreveu:
mglb updated this revision to Diff 47629.
mglb added a comment. View Revision https://phabricator.kde.org/D17607Remove redundant argument from setCss()
*CHANGES SINCE LAST UPDATE*
https://phabricator.kde.org/D17607?vs=47628&id=47629*BRANCH*
arc/Restore-previous-tabbar-look (branched from master)*REVISION DETAIL*
https://phabricator.kde.org/D17607*AFFECTED FILES*
src/ViewContainer.cpp
src/ViewContainer.h*To: *mglb, Konsole, VDG
*Cc: *konsole-devel, thsurrel, ngraham, maximilianocuria, hindenburg
Comment Actions
There is setDocumentMode(true); in constructor already. I didn't find any non-css way to remove it.
Comment Actions
I kinda like the line, but in a way I can't really explain, and not enough to object to this patch. :)
Comment Actions
There's still a line, there's just no margin. It looks especially good with Breeze Dark:
Comment Actions
I have (also) always trouble to see which tab is the active, at least with Dark theme. Would be nice you improve this even more.
Comment Actions
@loh.tar I agree this looks bad with so small (relatively) lines. But this is a thing for separate request for VDG. In the meantime, search for konsole stylesheets.