Differential D17605

Restore default tabbar style when custom stylesheet is disabled
ClosedPublic
Actions

Authored by mglb on Dec 15 2018, 4:41 PM.

Details

Reviewers
hindenburg
Group Reviewers
Konsole
Commits
R319:5260daa66e4f: Restore default tabbar style when custom stylesheet is disabled
R319:18e107bd32a1: Restore default tabbar style when custom stylesheet is disabled
Test Plan
  • Open new tab to show tabbar
  • Enable Use user-defined stylesheet in Konsole Settings
  • Set some stylesheet file; example contents:
QTabBar::tab { background-color: #0f0; border: 0; color: #000; }
  • Apply settings
  • Disable Use user-defined stylesheet in Konsole Settings
  • Apply settings

Actual result:
Custom style is still used by tabbar
Expected result:
Default tabbar style is restored

Diff Detail

Repository
R319 Konsole
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mglb requested review of this revision.Dec 15 2018, 4:41 PM
mglb created this revision.
hindenburg accepted this revision.Dec 15 2018, 8:49 PM
hindenburg added a subscriber: hindenburg.

thanks

This revision is now accepted and ready to land.Dec 15 2018, 8:49 PM
Closed by commit R319:5260daa66e4f: Restore default tabbar style when custom stylesheet is disabled (authored by mglb, committed by hindenburg). · Explain WhyDec 15 2018, 8:50 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/ViewContainer.cpp (2 lines)

Diff 47639

View Options

src/ViewContainer.cpp

Loading...