Differential D16867

Don't generate appstream data for files that lack a description
ClosedPublic
Actions

Authored by apol on Nov 13 2018, 4:11 PM.

Details

Reviewers
ngraham
Group Reviewers
Plasma
Frameworks
Commits
R290:3f9d17c940a1: Don't generate appstream data for files that lack a description
Summary

They end up being broken appstream files and it fails on the users' faces.
Have it as a warning to the developers instead.

BUG: 400431

Diff Detail

Repository
R290 KPackage
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 4909
Build 4927: arc lint + arc unit
apol created this revision.Nov 13 2018, 4:11 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptNov 13 2018, 4:11 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
apol requested review of this revision.Nov 13 2018, 4:11 PM
ngraham accepted this revision.Nov 13 2018, 6:14 PM
ngraham added a subscriber: ngraham.

Thanks, this looks like a good fix.

This revision is now accepted and ready to land.Nov 13 2018, 6:14 PM
apol closed this revision.Nov 21 2018, 2:49 AM
rikmills added a subscriber: rikmills.Nov 22 2018, 12:21 AM

And we have a casualty from this ;)

Marble 18.12 branch:

CMake Warning at /usr/lib/x86_64-linux-gnu/cmake/KF5Package/KF5PackageMacros.cmake:68 (message):
 couldn't generate metainfo for org.kde.plasma.worldmap: Package type
 "Plasma/Wallpaper" not found
 
 Error: description missing, will result in broken appdata field as
 <sumary/> is mandatory.
rikmills removed a subscriber: rikmills.Nov 22 2018, 1:17 AM
apol added a comment.Nov 30 2018, 4:25 PM

Tests fixed, sorry about that.

Revision Contents
Changeset List

PathPackages
Msrc/kpackagetool/kpackagetool.cpp (5 lines)

Diff 45420

View Options

src/kpackagetool/kpackagetool.cpp

Loading...