It probably should have been smbfs as everywhere else.
Details
Details
Cannot find any traces of subfs in the code. There's a FUSE for Subsonic media server called that way but I doubt it's this one given how old that piece of code is :)
Diff Detail
Diff Detail
- Repository
- R241 KIO
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
I doubt it's a typo.
"cifs" was the samba of the time
e9828078e17c8b1bd06c0a23e81e8eb6d720139e introducing it also references subfs in the commit message. It's unlikely it's two typos.
I think it's http://submount.sourceforge.net/
| src/core/kmountpoint.cpp | ||
|---|---|---|
| 550 | Here it is explicit smbfs, though, and I couldn't find any reference to subfs in kio code. I also tried to find in history when that was added but didn't graft | |
Comment Actions
Sure, it totally makes sense to add smbfs in the probablySlow. +1 on the core part of the patch.
I don't think subfs was a typo, and shouldn't be removed on that basis.
Comment Actions
I think removing subfs is fine, although in a different patch - needs oot kernel patch, linu 2.6.x era. Used for automounting removable media. Scope is the same as for supermount.
Comment Actions
commit bd86d99dda
Author: Adrian Schroeter <adrian@suse.de>
Date: Wed Apr 7 07:36:37 2004 +0000
do not use DNOTIFY on subfs mounted devices. this would lock the drive and make an eject impossible.
svn path=/trunk/kdelibs/; revision=301908
diff --git a/kio/kio/global.cpp b/kio/kio/global.cpp
index 046a68285f..ab0a65bd84 100644
--- a/kio/kio/global.cpp
+++ b/kio/kio/global.cpp
@@ -1561,7 +1561,7 @@ static void check_mount_point(const char *mounttype,
MountState &isslow, MountState &isautofs)
{
bool nfs = !strcmp(mounttype, "nfs");
- bool autofs = !strcmp(mounttype, "autofs");
+ bool autofs = !strcmp(mounttype, "autofs") || !strcmp(mounttype,"subfs");
bool pid = (strstr(fsname, ":(pid") != 0);
if (nfs && !pid)Not a typo. No idea if still applicable though.
Comment Actions
Obviously no typo:
https://phabricator.kde.org/source/kio/browse/master/tier3/kio/src/core/kmountpoint.cpp;1c03f632ea62f593ba88b65cad49e4e979d02ee3$542
but dead as a Dodo ...