Differential D12342

Update CMakeLists.txt
AbandonedPublic
Actions

Authored by elvisangelaccio on Apr 19 2018, 11:19 AM.

Details

Reviewers
michaelh
Group Reviewers
Baloo
Dolphin
Summary

Update CMakeLists.txt taking kwidgetsaddons as a template

Test Plan

make clean && make
Dolphin still runs

Diff Detail

Repository
R824 Baloo Widgets
Branch
bump (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
michaelh created this revision.Apr 19 2018, 11:19 AM
Restricted Application added a project: Baloo. · View Herald TranscriptApr 19 2018, 11:19 AM
michaelh requested review of this revision.Apr 19 2018, 11:19 AM
michaelh added a dependent revision: D11245: infopanel: Add choice of date display formats.
michaelh added inline comments.Apr 19 2018, 11:25 AM
CMakeLists.txt
4

There is not indication that baloo-widgets is an Application. Yet it resides in the kde/applications folder. Shouldn't it be moved into frameworks?

36

Leftovers from https://cgit.kde.org/baloo-widgets.git/commit/?id=bf4faa2f830d290a6a0f4bac471baec54aeeeba5

elvisangelaccio requested changes to this revision.Apr 21 2018, 10:22 AM
elvisangelaccio added inline comments.
CMakeLists.txt
4

It probably should, but in order to become a proper framework it has to satisfy the strict frameworks requirements: https://community.kde.org/Frameworks/Policies

In the meantime, if want to use the automatic versioning from release scripts (which is a good idea), we need to use the script of KDE Applications as described here: https://community.kde.org/Guidelines_and_HOWTOs/Application_Versioning

This revision now requires changes to proceed.Apr 21 2018, 10:22 AM
heikobecker added a subscriber: heikobecker.Apr 21 2018, 2:20 PM
heikobecker added inline comments.
CMakeLists.txt
4

There are other libraries released together with KDE Applications, eg. libkexiv2, libgravatar, libkgapi...

Besides the mentioned frameworks requirements, I also think frameworks should have more than one user (possibly across Applications/Plasma or Extragear). On my system only dolphin depends on baloo-widgets.

elvisangelaccio commandeered this revision.May 12 2018, 5:40 PM
elvisangelaccio abandoned this revision.
elvisangelaccio edited reviewers, added: michaelh; removed: elvisangelaccio.
elvisangelaccio added inline comments.
CMakeLists.txt
34–36

Superseded by fd1e2505b359.

@michaelh Feel free to push a commit that removes these 3 lines.

Revision Contents
Changeset List

PathPackages
MCMakeLists.txt (22 lines)

Diff 32547

View Options

CMakeLists.txt

Loading...