Remember the last-used save mode by default
ClosedPublic

Authored by ngraham on Jan 28 2018, 5:07 AM.

Details

Summary

Anecdotal evidence from bug triaging, internet forums, and reviews of KDE software suggests that 99% of Spectacle's users are unaware that this setting exists, and many would like its behavior turned on by default. This patch accomplishes that.

Test Plan

Tested in NDE Neon:

  • Removed ~/.config/spectaclerc
  • Opened Spectacle and confirmed that the button remembers the last-used save mode by default and that the applicable setting is toggled by default

Diff Detail

Repository
R166 Spectacle
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
ngraham requested review of this revision.Jan 28 2018, 5:07 AM
ngraham created this revision.
rkron added a comment.Jan 28 2018, 4:03 PM

I think this is a good idea. Spectacle already remembers the last-used capture mode, delay, etc., and this would make remembering the save mode consistent with that by default.

kossebau resigned from this revision.Jan 28 2018, 7:53 PM

Sorry, no own concepts about spectacle UI/UX, cannot comment anything useful.

FWIW @rkron, you can formally accept it if you want.

rkron accepted this revision.Jan 28 2018, 10:18 PM

@ngraham Gladly. I wasn't sure if I can, being so new to this.

This revision is now accepted and ready to land.Jan 28 2018, 10:18 PM
rkflx accepted this revision.EditedJan 28 2018, 10:52 PM
rkflx added a subscriber: rkflx.

FWIW, I'd love that. I'm still used to KSnapshot's Save As, and it always requires a huge effort to get something similar with Spectacle.

Code LGTM, but I wonder if there is a maintainer with an opinion or whether this topic has been discussed before?


Semi-related:

  • Remember selected area is another option I have to set on new user accounts everytime.
  • I guess this was intentional, but IMO (as a former KSnapshot user and from a usability perspective) combining Save and Exit is quite unusual, as well as the hidden access to Preferences.

Thanks @rkflx. Spectacle's formal maintainer @bgupta does not appear to be active anymore in its development, sadly.

I plan to resolve the Save & Exit and Preferences issues soon!

ngraham closed this revision.Jan 28 2018, 11:02 PM

BTW @rkflx, if you're interested in Spectacle's development, might you consider becoming a watcher for the project. Its members list is a bit sad right now. The same goes for you, @rkron!

BTW @rkflx, if you're interested in Spectacle's development, might you consider becoming a watcher for the project. Its members list is a bit sad right now. The same goes for you, @rkron!

Well, interest and time to spare are two different things, unfortunately (still working on my Gwenview + Okular backlogs…). Nevertheless happy to comment on UI stuff or to help reviewing e.g. in case @rkron wants to get his hands dirty… ;)

@ngraham I think I will do that. Thanks!