SpectacleProject
ActivePublic

Recent Activity

Today

fbampaloukas added a member for Spectacle: fbampaloukas.
Sun, Jun 16, 9:32 AM
fbampaloukas added a watcher for Spectacle: fbampaloukas.
Sun, Jun 16, 9:32 AM

Yesterday

anthonyfieroni added inline comments to D21638: Display delay in the taskmanager.
Sat, Jun 15, 1:11 PM · Spectacle
felixernst planned changes to D21651: Count down the seconds until a screenshot is taken in the window title.

But for now I'll wait until D21638: Display delay in the taskmanager has landed and I'll rebase to master then.

Sat, Jun 15, 10:03 AM · Spectacle
davidre added a comment to D21651: Count down the seconds until a screenshot is taken in the window title.

Wouldn't ceil do the same?

Sat, Jun 15, 7:40 AM · Spectacle

Wed, Jun 12

ngraham added a comment to T10574: Make shortcuts consistent.

Personally I think it would make sense to have the same shortcut for copy and non-copy with an additional modifier.
Also I am a fan of Meta + Print for taking a screenshot of the active window as it maps to the windows key on my laptop which is a great metaphor.

Wed, Jun 12, 3:21 PM · Spectacle
davidre updated the diff for D21638: Display delay in the taskmanager.
  • Also unminimize when screenshot fails/is canceled
Wed, Jun 12, 12:49 PM · Spectacle
broulik added inline comments to D21638: Display delay in the taskmanager.
Wed, Jun 12, 12:39 PM · Spectacle
davidre updated the diff for D21638: Display delay in the taskmanager.
  • Unused leftover
Wed, Jun 12, 12:22 PM · Spectacle
davidre added inline comments to D21638: Display delay in the taskmanager.
Wed, Jun 12, 12:16 PM · Spectacle
davidre updated the diff for D21638: Display delay in the taskmanager.
  • Use deleteLater() to delete Timer
Wed, Jun 12, 12:15 PM · Spectacle
broulik added inline comments to D21638: Display delay in the taskmanager.
Wed, Jun 12, 12:06 PM · Spectacle
davidre updated the task description for T10574: Make shortcuts consistent.
Wed, Jun 12, 8:36 AM · Spectacle

Sat, Jun 8

felixernst added a comment to D21638: Display delay in the taskmanager.

I think your setup simply exposes that the assumption that 200ms is enough is not always true.

Agreed.

Is there something special about it?

Not really. It is a desktop pc with seven year old hardware. It is not even that slow and granted that the bug doesn't happen in a virtual machine on this machine it doesn't seem to have anything to do with speed anyway. It has Kubuntu 18.04 installed though so maybe some interaction between the taskmanager or panels and the up to date spectacle leads to the needed delay. Or it might have something to do with https://bugs.kde.org/show_bug.cgi?id=376865 .

Sat, Jun 8, 1:41 PM · Spectacle
davidre added a comment to D21638: Display delay in the taskmanager.

I think your setup simply exposes that the assumption that 200ms is enough is not always true. Is there something special about it?

Sat, Jun 8, 1:23 PM · Spectacle
felixernst accepted D21638: Display delay in the taskmanager.

And for me it hides itself in time as it should

Sat, Jun 8, 12:41 PM · Spectacle
davidre added a comment to D21638: Display delay in the taskmanager.

If you look inside SpectacleCore::takeNewScreenshot there is already the delay added. And for me it hides itself in time as it should

Sat, Jun 8, 11:17 AM · Spectacle
felixernst requested changes to D21638: Display delay in the taskmanager.
Sat, Jun 8, 10:50 AM · Spectacle
felixernst added a comment to D21638: Display delay in the taskmanager.

This diff successfully fixes the indefinite hiding of the main window for me but now there is not enough time for the main window to hide in the task bar so the task bar always contains spectacle.

Sat, Jun 8, 10:45 AM · Spectacle
davidre updated the diff for D21638: Display delay in the taskmanager.
  • Start the capture timer only after the delay
Sat, Jun 8, 7:07 AM · Spectacle

Fri, Jun 7

felixernst updated the summary of D21651: Count down the seconds until a screenshot is taken in the window title.
Fri, Jun 7, 8:02 PM · Spectacle
felixernst requested review of D21651: Count down the seconds until a screenshot is taken in the window title.
Fri, Jun 7, 5:48 PM · Spectacle
felixernst added a dependent revision for D21638: Display delay in the taskmanager: D21651: Count down the seconds until a screenshot is taken in the window title.
Fri, Jun 7, 5:48 PM · Spectacle
ngraham added a comment to D21638: Display delay in the taskmanager.

UI feels great. Really nice feature.

Fri, Jun 7, 1:46 PM · Spectacle
davidre added inline comments to D21638: Display delay in the taskmanager.
Fri, Jun 7, 1:41 PM · Spectacle
davidre updated the test plan for D21638: Display delay in the taskmanager.
Fri, Jun 7, 1:41 PM · Spectacle
davidre updated the diff for D21638: Display delay in the taskmanager.

go back to continuous

Fri, Jun 7, 1:33 PM · Spectacle
felixernst added a comment to D21638: Display delay in the taskmanager.

I don't think having two different behaviors is a good idea. I fear that one could think that one or the other are broken.
With your feedback and from others I would say let's go with continuous.

+1

I like that idea! Maybe you can do a patch for that? :)

That's what I've been trying the last hour :D But I am quite new to Qt and kinda failing miserably so far. I'll keep trying.

Fri, Jun 7, 1:33 PM · Spectacle
davidre added a comment to D21638: Display delay in the taskmanager.

I have never done a review before and I feel like I am going a bit over the top with the testing here. But it's too late now. :)

Edit: I set up arcanist and tested your diff and everything is fine with the delay.
...
About the update rate: I think there are actually two different cases:
If the time is relatively low (<7s or something) then having an update every second isn't that helpful. For example for a 3s delay there would be two ticks total: 1/3 and 2/3. I think for these cases a smoothly filling bar would be best and look great.
For longer delay times a tick every second makes sense because one can very easily tell the rythm of the ticking if it happens 7 times or more. When one gets a feel for the ticking then one can tell exactly when the screenshot is going to be taken. I think a smoothly filling bar could work here as well though.

I don't think having two different behaviors is a good idea. I fear that one could think that one or the other are broken.
With your feedback and from others I would say let's go with continuous.

Another idea probably unrelated to this commit: Maybe the window title itself could additionally count down the seconds in the task manager. Like "Spectacle -- 3s"

I like that idea! Maybe you can do a patch for that? :)

Fri, Jun 7, 1:28 PM · Spectacle
felixernst added a comment to D21638: Display delay in the taskmanager.
Fri, Jun 7, 11:55 AM · Spectacle
felixernst added a comment to D21638: Display delay in the taskmanager.

I have never done a review before and I feel like I am going a bit over the top with the testing here. But it's too late now. :)

Fri, Jun 7, 10:59 AM · Spectacle
davidre updated the test plan for D21638: Display delay in the taskmanager.
Fri, Jun 7, 9:27 AM · Spectacle
davidre updated the diff for D21638: Display delay in the taskmanager.
  • Comments

I thought 1 second was a bit to long so trying 500ms now

Fri, Jun 7, 9:19 AM · Spectacle
broulik added a comment to D21638: Display delay in the taskmanager.

While I don't think my bits left in the code reach a neccessary threshold of originality, I agree to a relicensing from GPLv2 to LGPLv2+ (not sure why Spectacle as an application is *L*GPL, though)

Fri, Jun 7, 8:29 AM · Spectacle
davidre updated the diff for D21638: Display delay in the taskmanager.

Better default

Fri, Jun 7, 6:50 AM · Spectacle
davidre updated the summary of D21638: Display delay in the taskmanager.
Fri, Jun 7, 6:49 AM · Spectacle
davidre added 1 blocking reviewer(s) for D21638: Display delay in the taskmanager: broulik.

Because this is heavily based on @broulik work from KDevelop he needs to agree to relicensing his code from GPL 2 to LGPL 2.

Fri, Jun 7, 6:39 AM · Spectacle
davidre added reviewers for D21638: Display delay in the taskmanager: Spectacle, broulik, felixernst.
Fri, Jun 7, 6:36 AM · Spectacle
davidre requested review of D21638: Display delay in the taskmanager.
Fri, Jun 7, 6:33 AM · Spectacle

Wed, Jun 5

davidre closed D21556: Change defaultSaveLocation to use QUrl.
Wed, Jun 5, 1:45 PM · Spectacle

Mon, Jun 3

ngraham accepted D21556: Change defaultSaveLocation to use QUrl.

Shipit!

Mon, Jun 3, 8:12 PM · Spectacle
davidre added inline comments to D21556: Change defaultSaveLocation to use QUrl.
Mon, Jun 3, 7:34 PM · Spectacle
davidre updated the diff for D21556: Change defaultSaveLocation to use QUrl.

Remove leftover isReadable()

Mon, Jun 3, 7:34 PM · Spectacle
ngraham added inline comments to D21556: Change defaultSaveLocation to use QUrl.
Mon, Jun 3, 7:30 PM · Spectacle
davidre updated the summary of D21556: Change defaultSaveLocation to use QUrl.
Mon, Jun 3, 5:29 PM · Spectacle
davidre added inline comments to D21556: Change defaultSaveLocation to use QUrl.
Mon, Jun 3, 9:45 AM · Spectacle
davidre updated the diff for D21556: Change defaultSaveLocation to use QUrl.
  • change to Qurl
Mon, Jun 3, 9:42 AM · Spectacle
davidre retitled D21556: Change defaultSaveLocation to use QUrl from Fix default save location to Change defaultSaveLocation to use QUrl.
Mon, Jun 3, 9:41 AM · Spectacle
davidre added a comment to D21556: Change defaultSaveLocation to use QUrl.

Shouldn't that return a QUrl with QUrl::fromLocalFile then?

Mon, Jun 3, 9:40 AM · Spectacle
broulik added a comment to D21556: Change defaultSaveLocation to use QUrl.

Shouldn't that return a QUrl with QUrl::fromLocalFile then?

Mon, Jun 3, 8:40 AM · Spectacle