SpectacleProject
ActivePublic

Recent Activity

Yesterday

ngraham updated the test plan for D25883: Find qdbus command correctly.
Thu, Dec 12, 8:38 PM · Spectacle
ngraham added a comment to D25883: Find qdbus command correctly.

The Qt binaries dir is only versioned for major versions (4, 5, 6) so the path does not become invalid when you upgrade minor Qt versions.

Thu, Dec 12, 8:38 PM · Spectacle
fvogt added a comment to D25883: Find qdbus command correctly.

I'm wondering whether this might not actually break the "qtchooser" variant - if binaries are in a Qt version specific dir, the path to qdbus would no longer exist after a Qt update without a rebuild of spectacle.

Thu, Dec 12, 7:03 PM · Spectacle
ngraham added inline comments to D25883: Find qdbus command correctly.
Thu, Dec 12, 10:33 AM · Spectacle

Wed, Dec 11

kossebau added inline comments to D25883: Find qdbus command correctly.
Wed, Dec 11, 2:20 PM · Spectacle
ngraham updated the summary of D25883: Find qdbus command correctly.
Wed, Dec 11, 1:29 PM · Spectacle
ngraham updated the summary of D25883: Find qdbus command correctly.
Wed, Dec 11, 1:17 PM · Spectacle
ngraham updated the diff for D25883: Find qdbus command correctly.

Find the Qt binaries dir in a safer way

Wed, Dec 11, 1:17 PM · Spectacle
davidre added a comment to D25883: Find qdbus command correctly.

The best possible way of course would be that we support activating desktop actions via dbus and do so in kglobalaccel:
https://specifications.freedesktop.org/desktop-entry-spec/desktop-entry-spec-latest.html#dbus

Wed, Dec 11, 1:14 PM · Spectacle
fvogt added a comment to D25883: Find qdbus command correctly.

the actual name of the command is qdbus-qt<version> in the distro's Qt

Wed, Dec 11, 1:07 PM · Spectacle
ngraham added a comment to D25883: Find qdbus command correctly.

Right, I don't think that's ever expected to work.

Wed, Dec 11, 1:05 PM · Spectacle
davidre added a comment to D25883: Find qdbus command correctly.

Hmm that requires that we have qtpaths at build time which is for example shipped in qttools5-dev-tools. And that between build system and run time qdbus is in the same location. Is that an assumption we can make?

Wed, Dec 11, 12:57 PM · Spectacle
ngraham abandoned D25293: Use dbus-send instead of qdbus for global shortcuts.

Found a better way that doesn't involve going insane trying to make dbus-send work: D25883

Wed, Dec 11, 12:53 PM · Spectacle
ngraham requested review of D25883: Find qdbus command correctly.
Wed, Dec 11, 12:53 PM · Spectacle

Mon, Dec 9

ngraham added inline comments to D23446: Shortcuts displayed in capture mode ComboBox.
Mon, Dec 9, 7:47 PM · Spectacle

Fri, Dec 6

ngraham added a comment to D23316: Port towards KConfig XT.

Youre font seems bolder? Anyways we can easily increase the height.

Fri, Dec 6, 4:02 PM · Spectacle
ngraham closed D23723: Save image to clipboard if --nonotify is used.
Fri, Dec 6, 1:37 PM · Spectacle
davidre updated the diff for D23316: Port towards KConfig XT.

Rebase once more

Fri, Dec 6, 8:20 AM · Spectacle
davidre added a comment to D23316: Port towards KConfig XT.

All functionality works perfectly for me. However this regressed the default width of the settings window. Not it's not wide enough to accommodate all controls without an ugly horizontal scrollbar:

Fri, Dec 6, 8:17 AM · Spectacle
davidre requested changes to D23446: Shortcuts displayed in capture mode ComboBox.
Fri, Dec 6, 8:11 AM · Spectacle
davidre added a comment to D23446: Shortcuts displayed in capture mode ComboBox.

I still think this a cool feature, but I have the feeling this can be done in a much shorter patch. This seems to me a bit like overkill. Would be awesome if maybe somebody else could weigh in.

Fri, Dec 6, 8:07 AM · Spectacle
davidre accepted D23723: Save image to clipboard if --nonotify is used.
Fri, Dec 6, 7:58 AM · Spectacle

Thu, Dec 5

ngraham requested changes to D23316: Port towards KConfig XT.

All functionality works perfectly for me. However this regressed the default width of the settings window. Not it's not wide enough to accommodate all controls without an ugly horizontal scrollbar:

Thu, Dec 5, 10:36 PM · Spectacle
ngraham added a comment to D23723: Save image to clipboard if --nonotify is used.

@davidre, is this okay now?

Thu, Dec 5, 10:19 PM · Spectacle
davidre closed D25765: Fix issue preventing spectacle from opening.
Thu, Dec 5, 3:18 PM · Spectacle
ngraham accepted D25765: Fix issue preventing spectacle from opening.

Nice catch.

Thu, Dec 5, 3:14 PM · Spectacle
davidre requested review of D25765: Fix issue preventing spectacle from opening.
Thu, Dec 5, 3:08 PM · Spectacle
davidre updated the diff for D23316: Port towards KConfig XT.

rebase

Thu, Dec 5, 1:47 PM · Spectacle
davidre updated the diff for D23316: Port towards KConfig XT.

Need a bit more height

Thu, Dec 5, 1:45 PM · Spectacle

Tue, Nov 26

davidre updated the diff for D23316: Port towards KConfig XT.

Correctly read default value dependent on another config entry

Tue, Nov 26, 9:49 AM · Spectacle

Fri, Nov 22

guoyunhe added a comment to D25475: Save combobox value instead of index.

Yeah, look exactly the same, maybe yours is better (with configuration update script). We can close this one when yours get accepted.

Fri, Nov 22, 9:50 PM · Spectacle
davidre added a comment to D25475: Save combobox value instead of index.

I added a similar fix earlier today to
D23316

Fri, Nov 22, 9:28 PM · Spectacle
guoyunhe added a reviewer for D25475: Save combobox value instead of index: Spectacle.
Fri, Nov 22, 8:16 PM · Spectacle
guoyunhe requested review of D25475: Save combobox value instead of index.
Fri, Nov 22, 8:16 PM · Spectacle
davidre updated the diff for D23316: Port towards KConfig XT.

Also use enum for the last selected captureMode

Fri, Nov 22, 12:19 PM · Spectacle

Thu, Nov 21

davidre updated the diff for D23316: Port towards KConfig XT.
  • Fix typo in update file
Thu, Nov 21, 3:11 PM · Spectacle
ervin added a comment to D23316: Port towards KConfig XT.

LGTM, I'd still aim for the .ui port as a second step though.

Thu, Nov 21, 11:30 AM · Spectacle
davidre updated the diff for D23316: Port towards KConfig XT.

address comments

Thu, Nov 21, 9:58 AM · Spectacle

Mon, Nov 18

ervin added a comment to D23316: Port towards KConfig XT.

Looks good to me regarding the kconfig_compiler use (epsilon one key which would be better suited to an enum).
The next natural step would be to switch the dialog pages to ui files, that would remove some more code.

If we have to port it to anything, I'd prefer a QML-based UI rather than making new .ui files.

Mon, Nov 18, 5:05 PM · Spectacle
ngraham added a comment to D23316: Port towards KConfig XT.

Looks good to me regarding the kconfig_compiler use (epsilon one key which would be better suited to an enum).
The next natural step would be to switch the dialog pages to ui files, that would remove some more code.

Mon, Nov 18, 4:15 PM · Spectacle
crossi added inline comments to D23316: Port towards KConfig XT.
Mon, Nov 18, 1:26 PM · Spectacle
ervin added a comment to D23316: Port towards KConfig XT.

Looks good to me regarding the kconfig_compiler use (epsilon one key which would be better suited to an enum).
The next natural step would be to switch the dialog pages to ui files, that would remove some more code.

Mon, Nov 18, 7:31 AM · Spectacle

Thu, Nov 14

ngraham added a comment to D25293: Use dbus-send instead of qdbus for global shortcuts.

Yeah, now that you mention it, I notice that too.

Thu, Nov 14, 4:08 PM · Spectacle
davidre added a comment to D25293: Use dbus-send instead of qdbus for global shortcuts.

Sorry, it doesn't work for me either. I didn't relog before testing and I guess it was still using the qdbus commands. KLauncher gets the right arguments I think:

What does this mean? Sorry, I'm pretty new to dbus.

I don't know but KGlobalAccel uses KLauncher to execute the command found in the Exec line of the desktop file.
However I noticed something weird when manually using your dbus-send commands. dbus-send --session --dest='org.kde.Spectacle' --type=method_call '/' 'org.kde.Spectacle.StartAgent' only seemed to work every second time.

Thu, Nov 14, 3:06 PM · Spectacle
ngraham added a comment to D25293: Use dbus-send instead of qdbus for global shortcuts.

Sorry, it doesn't work for me either. I didn't relog before testing and I guess it was still using the qdbus commands. KLauncher gets the right arguments I think:

Thu, Nov 14, 2:40 PM · Spectacle
davidre updated subscribers of D23316: Port towards KConfig XT.

Maybe we can do this for 20.03 with 19.12 now branched. This would leave us some time to test it. What do you think @ngraham?

Thu, Nov 14, 11:35 AM · Spectacle
davidre requested changes to D25293: Use dbus-send instead of qdbus for global shortcuts.
Thu, Nov 14, 8:07 AM · Spectacle
davidre added a comment to D25293: Use dbus-send instead of qdbus for global shortcuts.

Sorry, it doesn't work for me either. I didn't relog before testing and I guess it was still using the qdbus commands. KLauncher gets the right arguments I think:

Thu, Nov 14, 8:07 AM · Spectacle
fvogt added a comment to D25293: Use dbus-send instead of qdbus for global shortcuts.

It doesn't seem to work here either, but adding the --print-reply argument helps for some reason.

Thu, Nov 14, 7:59 AM · Spectacle

Wed, Nov 13

ngraham added a comment to D25293: Use dbus-send instead of qdbus for global shortcuts.

Shortcuts work for me. For testing make sure to install to /usr

Wed, Nov 13, 10:59 PM · Spectacle