SpectacleProject
ActivePublic

Recent Activity

Today

ngraham added a comment to D28395: Added CopyToClipboard parameter to dbus RectangularRegion and set up shortcut keys.

Sorry, I'll try to get to this soon.

Tue, Apr 7, 4:23 PM · Spectacle
jatinsharma added a comment to D28395: Added CopyToClipboard parameter to dbus RectangularRegion and set up shortcut keys.

Any updates on this?

Tue, Apr 7, 1:22 PM · Spectacle

Mon, Mar 30

davidre closed D28315: Rework file numbering.
Mon, Mar 30, 2:11 PM · Spectacle
ngraham accepted D28315: Rework file numbering.
Mon, Mar 30, 1:43 PM · Spectacle
davidre updated the diff for D28315: Rework file numbering.

remove leftover qdebug

Mon, Mar 30, 1:43 PM · Spectacle
ngraham added inline comments to D28315: Rework file numbering.
Mon, Mar 30, 1:41 PM · Spectacle
jatinsharma added a comment to D28395: Added CopyToClipboard parameter to dbus RectangularRegion and set up shortcut keys.

I did this only for a single function to get feedback on whether this approach was acceptable.

Mon, Mar 30, 12:04 PM · Spectacle
davidre updated subscribers of D28395: Added CopyToClipboard parameter to dbus RectangularRegion and set up shortcut keys.

I don't think this is the right approach. You are just changing it for one method. Maybe we could make it configurable in settings,
Currently we have

After taking a screenshot: - Save
                                                  - Copy

That only applies when the gui is running Maybe we could find a solution to have it also apply when the ui is not up? Something like the above and a setting what should happen if you press shortcuts? What do you think @ngraham?

Mon, Mar 30, 7:51 AM · Spectacle
broulik added a comment to D28395: Added CopyToClipboard parameter to dbus RectangularRegion and set up shortcut keys.

Thanks for your patch.
However, I think you shouldn't change the existing method signature.

Mon, Mar 30, 6:53 AM · Spectacle

Sun, Mar 29

jatinsharma added a comment to T11418: DBus mode settings.

Hello, I've just submitted D28395 which adds the copy to clipboard capability for DBus, which this discussion mentions.
I had not seen this discussion earlier. Have I redone any already done work?

Sun, Mar 29, 3:22 AM · Spectacle
jatinsharma added a reviewer for D28395: Added CopyToClipboard parameter to dbus RectangularRegion and set up shortcut keys: Spectacle.
Sun, Mar 29, 3:07 AM · Spectacle
jatinsharma requested review of D28395: Added CopyToClipboard parameter to dbus RectangularRegion and set up shortcut keys.
Sun, Mar 29, 3:01 AM · Spectacle
jatinsharma added a watcher for Spectacle: jatinsharma.
Sun, Mar 29, 2:32 AM

Thu, Mar 26

davidre requested review of D28315: Rework file numbering.
Thu, Mar 26, 4:48 PM · Spectacle

Thu, Mar 19

guoyunhe abandoned D25475: Save combobox value instead of index.

Can be closed.

Thu, Mar 19, 9:11 PM · Spectacle
davidre added a comment to D25475: Save combobox value instead of index.

It should not

Thu, Mar 19, 8:08 PM · Spectacle
ngraham added a comment to D25475: Save combobox value instead of index.

Is this still relevant with D23316 committed now?

Thu, Mar 19, 7:38 PM · Spectacle

Tue, Mar 17

ngraham accepted D27969: Fix %T filename pattern in fullscreen captures.

Looks and behaves nicely to me, but I am not a regex expert by any stretch of the imagination. @davidre, does this look okay to you?

Tue, Mar 17, 12:23 AM · Spectacle

Mon, Mar 16

davidre closed D28080: Remove hack for QButtonBox.
Mon, Mar 16, 5:48 PM · Spectacle
davidre updated the diff for D28080: Remove hack for QButtonBox.

Make xml nicer

Mon, Mar 16, 5:42 PM · Spectacle
ngraham accepted D28080: Remove hack for QButtonBox.

20.04 is fine IMO.

Mon, Mar 16, 5:38 PM · Spectacle
davidre added a comment to D28080: Remove hack for QButtonBox.

Any advice if master only or also 20.04?

Mon, Mar 16, 5:31 PM · Spectacle
davidre requested review of D28080: Remove hack for QButtonBox.
Mon, Mar 16, 5:29 PM · Spectacle

Wed, Mar 11

davidre closed D23316: Port towards KConfig XT.
Wed, Mar 11, 10:15 AM · Spectacle
broulik accepted D23316: Port towards KConfig XT.
Wed, Mar 11, 10:11 AM · Spectacle

Tue, Mar 10

ngraham added a reviewer for D27969: Fix %T filename pattern in fullscreen captures: Spectacle.
Tue, Mar 10, 3:15 PM · Spectacle
aureliencouderc added a comment to D27969: Fix %T filename pattern in fullscreen captures.

Will try. :-)

Tue, Mar 10, 2:22 PM · Spectacle
davidre added a comment to D27969: Fix %T filename pattern in fullscreen captures.

Could you please a test case for that?

Tue, Mar 10, 12:53 PM · Spectacle
aureliencouderc requested review of D27969: Fix %T filename pattern in fullscreen captures.
Tue, Mar 10, 12:34 PM · Spectacle

Mar 6 2020

Leon0402 added a comment to D27829: Add mobile interface.

I don't have a strong opinion either. I just thought that it could be of interest to capture only the app itself. Maybe at least for developers?
I think most users are primarly interested in the normal screenshot function and the other features are rather niche. (But it's hided in a popup and it's already there, so I see no particular reason to not have it)

Mar 6 2020, 10:12 AM · Spectacle

Mar 5 2020

ngraham added a comment to D27829: Add mobile interface.

Thanks a lot Nate!

I agree, the "window under cursor" mode makes no sense. Regarding the "aktive window" mode, I think it makes sense as it doesn't capture the system try?

Mar 5 2020, 5:38 PM · Spectacle
Leon0402 added a comment to D27829: Add mobile interface.

Thanks a lot Nate!

Mar 5 2020, 11:57 AM · Spectacle
Leon0402 updated the diff for D27829: Add mobile interface.
  • Fix button bug
Mar 5 2020, 11:39 AM · Spectacle

Mar 4 2020

ngraham requested changes to D27829: Add mobile interface.

This is really cool!

Mar 4 2020, 10:44 PM · Spectacle
Leon0402 added a comment to D27829: Add mobile interface.

First it doesn't load. Because you hardcode the path to "src/MobileFrontend/main.qml" and don't even install the qml files it only works when spectacle is run from the source directory. I don't get the difference between mobile frontend and mobile backend. To me it looks like both are frontend and the backend class does only connect some signals.

Mar 4 2020, 3:26 PM · Spectacle
Leon0402 updated the diff for D27829: Add mobile interface.
  • Change structure
Mar 4 2020, 3:03 PM · Spectacle
davidre added a comment to D27829: Add mobile interface.

Nice! First comments after quick look. Will try to find time this week for a more detailed review

Mar 4 2020, 1:40 PM · Spectacle
Leon0402 added reviewers for D27829: Add mobile interface: Spectacle, VDG, nicolasfella.
Mar 4 2020, 11:39 AM · Spectacle
Leon0402 requested review of D27829: Add mobile interface.
Mar 4 2020, 11:38 AM · Spectacle

Feb 28 2020

ngraham added a comment to D22074: Add image annotation via libKImageAnnotator.

@nicolasfella ping! Any chance of getting this in for 20.04?

Feb 28 2020, 4:08 AM · Spectacle

Feb 25 2020

davidre closed D27373: Port general settings and save setting to ui files.
Feb 25 2020, 6:44 PM · Spectacle

Feb 24 2020

ervin accepted D27373: Port general settings and save setting to ui files.
Feb 24 2020, 3:26 PM · Spectacle
davidre updated the diff for D27373: Port general settings and save setting to ui files.

Use qscopedpointer

Feb 24 2020, 1:53 PM · Spectacle
ervin added inline comments to D27373: Port general settings and save setting to ui files.
Feb 24 2020, 1:47 PM · Spectacle
davidre added inline comments to D27373: Port general settings and save setting to ui files.
Feb 24 2020, 1:10 PM · Spectacle
ervin added inline comments to D27373: Port general settings and save setting to ui files.
Feb 24 2020, 12:42 PM · Spectacle

Feb 21 2020

davidre added inline comments to D27373: Port general settings and save setting to ui files.
Feb 21 2020, 7:49 AM · Spectacle
davidre closed D27415: Use KConfigDialogManager to manage main window settings.
Feb 21 2020, 7:37 AM · Spectacle
davidre updated the summary of D27415: Use KConfigDialogManager to manage main window settings.
Feb 21 2020, 7:36 AM · Spectacle

Feb 17 2020

ervin added a comment to D27373: Port general settings and save setting to ui files.

Couple of nitpicks, feel free to ignore

Feb 17 2020, 11:08 AM · Spectacle