Awesome.

I am continuing work on this feature here: https://invent.kde.org/graphics/spectacle/-/merge_requests/129 (My code is loosely based on Leon's. I wasn't able to help with pushing this MR over the finish line back then but I always wanted to see this actually get merged.)

perfect.

This is in progress with https://invent.kde.org/graphics/spectacle/-/merge_requests/119

Hi @acrouthamel ! Do you have any further information about the kwin functionality? was it in any way used? Or is anybody working on this?

Resolved by adding an option in https://invent.kde.org/graphics/spectacle/-/merge_requests/71.

Done in Spectacle 20.08 IIRC.

Sweet!

Awesome feature!

Thanks for the feedback. Totally understand that the rectangular region capture mode is a desirable feature and that it is not an option to drop it.

It doesn't work when trying to capture open menus. At least on X11, menus close when doing the capture.

In D29282#676586, @czeidler wrote:

I am the author of D29550 which adds supports for a post capture selection option for already taken screenshots. D29550 is currently blocked by this patch.

After giving it a good thought, I see the following general problems with the existing rectangular region capture mode:

1. It doesn't work when trying to capture open menus. At least on X11, menus close when doing the capture.
2. By supporting different screen scales, the QuickEditor code becomes very complex. I wouldn't feel comfortable applying a patch while keeping all the screen scaling in mind. I would have to invest quite some time to get a deep understanding of the scaling problem and even then I doubt I could make changes without introducing any new issues, which brings me to the next point.
3. Testing, how do we test any changes? With X11, Wayland, scaling factors, monitor positions and X QuickEditor features there seem to be too many combinations to test properly. Especially, I don't see a reliable and easy way to automate these kind of tests.
4. All the hard bits of translating real screen position to window positions which is already done by the display server needs to be redone in QuickEditor (more or less). Not really a problem but also not a nice thing to do.
   
   For this reason I suggest the following approach: a) Compose the screen capture(s) into a single pixmap as it is done already. b) Drop support for rectangular region capture mode in favour of the post selection mode in D29550 which operates on this pixmap.
   
   This has the advantage that a) and b) are completely decoupled. How the pixmap is composed can easily be changed and screen scales can be applied as desired. QuickEditor stays relatively simple and straightforward to modify.

Replaced by https://invent.kde.org/graphics/spectacle/-/merge_requests/29

I am the author of D29550 which adds supports for a post capture selection option for already taken screenshots. D29550 is currently blocked by this patch.

Yaayy!

Merging this as discussed in the VDG chat

Can this be moved over to invent.kde.org and merged?

For now this patch is blocked until we can get the screen scale factor from somewhere else than libkscreen.

In D29282#676011, @meven wrote:

In D29282#676008, @ngraham wrote:

Tried this out and Rectangular Region mode disappeared from the combobox.

I think this is because there is a now check in spectacle that plasma is > 5.20 for the shuttermode.

Should check for > 5.19.80 then

In D29282#676008, @ngraham wrote:

Tried this out and Rectangular Region mode disappeared from the combobox.

I think this is because there is a now check in spectacle that plasma is > 5.20 for the shuttermode.
You can edit the PlatformKWinWayland::supportedShutterModes to work locally.
The patch needs adjustment.

Would be really nice to finally get this in.

Tried this out and Rectangular Region mode disappeared from the combobox.

Rebased on master

Ah, that sounds like a sensible idea.

In D29282#675339, @ngraham wrote:

Needs a rebase.

Needs a rebase.

Not really needed now that the notification has a hamburger menu on it.

Needs https://invent.kde.org/graphics/spectacle/-/merge_requests/5 after latest D29408 changes

Check Plasma major version, use splitRef

Make raw DBus call

In D29408#674966, @meven wrote:

In D29408#674962, @davidre wrote:

I think we shouldn't use QDBUsInterface but given that we already do this is probably ok

The alternative is just less documented AFAICT.
IRC the alternative is about adding xml files that generate code.

In D29408#674962, @davidre wrote:

I think we shouldn't use QDBUsInterface but given that we already do this is probably ok

I think we shouldn't use QDBUsInterface but given that we already do this is probably ok

Very short nice!

I am abandonning https://invent.kde.org/frameworks/kdbusaddons/-/merge_requests/1/diffs.

Check only once the plasma version when needed

Avoid adding the dependency to spectacle

This adds a dependency on https://invent.kde.org/frameworks/kdbusaddons/-/merge_requests/1/diffs

Use KDBusAddon' PlasmaVersion

https://invent.kde.org/graphics/spectacle/-/merge_requests/3 was merged