rkron (Randy Kron)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Jan 16 2018, 1:11 AM (74 w, 1 d)
Availability
Available

Recent Activity

May 27 2018

rkron added a comment to D11685: Implement single click on line number to select line of text.

Yes, tested and it works.

May 27 2018, 10:05 PM · Frameworks, Kate

Apr 26 2018

rkron added a comment to D11685: Implement single click on line number to select line of text.

Would someone please land this for me? Thanks.

Apr 26 2018, 7:17 AM · Frameworks, Kate

Apr 6 2018

rkron updated the test plan for D11685: Implement single click on line number to select line of text.
Apr 6 2018, 4:13 PM · Frameworks, Kate
rkron updated the diff for D11685: Implement single click on line number to select line of text.
  • Revise patch per review comments.
Apr 6 2018, 4:10 PM · Frameworks, Kate

Apr 2 2018

rkron updated the diff for D11685: Implement single click on line number to select line of text.
  • Removed two unnecessary lines in patch.
Apr 2 2018, 11:58 PM · Frameworks, Kate

Mar 28 2018

rkron added a reviewer for D11685: Implement single click on line number to select line of text: cullmann.
Mar 28 2018, 12:28 PM · Frameworks, Kate

Mar 26 2018

rkron updated the test plan for D11685: Implement single click on line number to select line of text.
Mar 26 2018, 9:57 PM · Frameworks, Kate

Mar 25 2018

rkron updated the diff for D11685: Implement single click on line number to select line of text.
  • Update revision per review comments.

Removed the config option to enable and disable the single-click behavior.

Mar 25 2018, 8:30 PM · Frameworks, Kate
rkron added a comment to D11685: Implement single click on line number to select line of text.

@ngraham Qt Designer made those changes when I added the checkbox. They will be gone with the update. The four files concerning the config option will be as they were before this revision.

Mar 25 2018, 8:22 PM · Frameworks, Kate
rkron added a comment to D11685: Implement single click on line number to select line of text.

And actually, if you have the line modification marker border turned on, clicking in it will just move the cursor without selecting the line.

Mar 25 2018, 8:16 PM · Frameworks, Kate
rkron added a comment to D11685: Implement single click on line number to select line of text.

@ngraham I agree. Single-click is pretty much standard.

Mar 25 2018, 8:11 PM · Frameworks, Kate
rkron added a comment to D11685: Implement single click on line number to select line of text.

OK. I will remove the option and update the revision. Thanks for the input!

Mar 25 2018, 7:55 PM · Frameworks, Kate
rkron added a comment to D11685: Implement single click on line number to select line of text.

If you think it should be on by default, that's easily done. I know what you mean, that nobody would ever find it.

Mar 25 2018, 7:37 PM · Frameworks, Kate
rkron updated the test plan for D11685: Implement single click on line number to select line of text.
Mar 25 2018, 2:26 PM · Frameworks, Kate
rkron requested review of D11685: Implement single click on line number to select line of text.
Mar 25 2018, 2:19 PM · Frameworks, Kate

Feb 4 2018

rkron abandoned D10147: Make Gwenview statusbar render correctly when using QtCurve theme.

There are other parentless widgets in gwenview that do not have this problem. It must take some unique combination of various factors for it to show up. It should be fixed in qtcurve, if possible.

Feb 4 2018, 1:05 PM · KDE Applications
rkron removed a watcher for Spectacle: rkron.
Feb 4 2018, 12:54 PM

Feb 2 2018

rkron added a comment to D10147: Make Gwenview statusbar render correctly when using QtCurve theme.

I'm on my phone now and can't look at anything, but as for the why… What I remember is that qtcurve has a hook for X window creation that is only used when there is transparency (less than 100% opacity) and it makes a difference if the widget has a parent at the time. I worked with the qtcurve code a little and thought I had it so the parent issue didn't matter, but then I found it killed the transparency, so that was no fix.

Feb 2 2018, 10:02 PM · KDE Applications
rkron added a comment to D10147: Make Gwenview statusbar render correctly when using QtCurve theme.

Sorry, it may be a while before I can think about this now. My dear friend went to the ER today and is in the hospital.

Feb 2 2018, 9:34 PM · KDE Applications
rkron added a comment to D10147: Make Gwenview statusbar render correctly when using QtCurve theme.

FWIW, I've been using the patched version for about a month and there has been no problem. Glad to have someone else try it out also.

Feb 2 2018, 4:47 PM · KDE Applications
rkron added a comment to D10147: Make Gwenview statusbar render correctly when using QtCurve theme.

Maybe this is hardware or driver dependent. I think I will abandon this revision unless anyone has some other thoughts.

Feb 2 2018, 12:13 AM · KDE Applications

Feb 1 2018

rkron added a comment to D10147: Make Gwenview statusbar render correctly when using QtCurve theme.

@ngraham I tested it again just now with Breeze and Oxygen and both are OK.
@rizzitello I also use arch and I have this issue with the version you mention. The window opacity (on the opacity page of the qtcurve config dialog) has to be something less than 100% for this issue to show up.
@rkflx Thanks!

Feb 1 2018, 11:12 PM · KDE Applications

Jan 31 2018

rkron accepted D10198: Make "Save As" the default save mode.

Looks good.

Jan 31 2018, 1:35 PM

Jan 29 2018

rkron added a watcher for Spectacle: rkron.
Jan 29 2018, 12:32 AM
rkron added a comment to D10153: Remember the last-used save mode by default.

@ngraham I think I will do that. Thanks!

Jan 29 2018, 12:31 AM

Jan 28 2018

rkron accepted D10153: Remember the last-used save mode by default.

@ngraham Gladly. I wasn't sure if I can, being so new to this.

Jan 28 2018, 10:18 PM
rkron added a comment to D10153: Remember the last-used save mode by default.

I think this is a good idea. Spectacle already remembers the last-used capture mode, delay, etc., and this would make remembering the save mode consistent with that by default.

Jan 28 2018, 4:03 PM
rkron added a reviewer for D10146: Further improve quality of images in notifications (Bug 385097): ngraham.
Jan 28 2018, 1:17 PM · Spectacle, Plasma

Jan 27 2018

rkron closed D9993: Improve quality of images in notifications (Bug 385097).

Submitting new revision.

Jan 27 2018, 3:09 PM · Spectacle, Plasma
rkron added a comment to D9993: Improve quality of images in notifications (Bug 385097).

@ngraham Thanks Nathaniel!

Jan 27 2018, 3:08 PM · Spectacle, Plasma
rkron added a comment to D9993: Improve quality of images in notifications (Bug 385097).

@ngraham So should I submit this new patch as a new revision? I'm still new to this.

Jan 27 2018, 2:58 PM · Spectacle, Plasma
rkron added a comment to D9993: Improve quality of images in notifications (Bug 385097).

@ngraham This is in addition to the last patch, Nate. It needs both, and this diff is off the current state of the repo. When I first looked into this, I tried setting ScaleType but it had no effect. Then I found that the preview image was being scaled based on the small vertical height that was being requested, which led to the first patch. I should have tried setting ScaleType again.

Jan 27 2018, 2:38 PM · Spectacle, Plasma
rkron reopened D9993: Improve quality of images in notifications (Bug 385097).

See my comment with the new patch.

Jan 27 2018, 2:06 PM · Spectacle, Plasma
rkron updated the diff for D9993: Improve quality of images in notifications (Bug 385097).

I'm sorry for all the trouble, but I found the way to produce really clear previews.

Jan 27 2018, 2:04 PM · Spectacle, Plasma

Jan 21 2018

rkron added a comment to D9928: Fix one source of log spam referenced in Bug 388389 (Empty filename passed to function).

@davidedmundson Thanks for the commit!

Jan 21 2018, 4:06 PM · Frameworks

Jan 20 2018

rkron added a comment to D9928: Fix one source of log spam referenced in Bug 388389 (Empty filename passed to function).

I'm new to phabricator and do not have commit access. Does someone need to commit this?

Jan 20 2018, 10:17 PM · Frameworks
rkron added a comment to D9993: Improve quality of images in notifications (Bug 385097).

@broulik I'm new to phabricator and do not have commit access. Please commit for me. Thanks.

Jan 20 2018, 10:12 PM · Spectacle, Plasma
rkron updated the summary of D9993: Improve quality of images in notifications (Bug 385097).
Jan 20 2018, 4:52 PM · Spectacle, Plasma

Jan 17 2018

rkron updated the diff for D9928: Fix one source of log spam referenced in Bug 388389 (Empty filename passed to function).

After reviewing the kio commit where similar changes were made, I changed QFile::exists to QFileInfo::exists as was done in kio and have updated my patch. I should have looked at kio before my first submission. Sorry.

Jan 17 2018, 1:45 PM · Frameworks