- User Since
- Jan 16 2018, 1:11 AM (87 w, 4 d)
May 27 2018
Yes, tested and it works.
Apr 26 2018
Would someone please land this for me? Thanks.
Apr 6 2018
- Revise patch per review comments.
Apr 2 2018
- Removed two unnecessary lines in patch.
Mar 28 2018
Mar 26 2018
Mar 25 2018
- Update revision per review comments.
Removed the config option to enable and disable the single-click behavior.
@ngraham Qt Designer made those changes when I added the checkbox. They will be gone with the update. The four files concerning the config option will be as they were before this revision.
And actually, if you have the line modification marker border turned on, clicking in it will just move the cursor without selecting the line.
@ngraham I agree. Single-click is pretty much standard.
OK. I will remove the option and update the revision. Thanks for the input!
If you think it should be on by default, that's easily done. I know what you mean, that nobody would ever find it.
Feb 4 2018
There are other parentless widgets in gwenview that do not have this problem. It must take some unique combination of various factors for it to show up. It should be fixed in qtcurve, if possible.
Feb 2 2018
I'm on my phone now and can't look at anything, but as for the why… What I remember is that qtcurve has a hook for X window creation that is only used when there is transparency (less than 100% opacity) and it makes a difference if the widget has a parent at the time. I worked with the qtcurve code a little and thought I had it so the parent issue didn't matter, but then I found it killed the transparency, so that was no fix.
Sorry, it may be a while before I can think about this now. My dear friend went to the ER today and is in the hospital.
FWIW, I've been using the patched version for about a month and there has been no problem. Glad to have someone else try it out also.
Maybe this is hardware or driver dependent. I think I will abandon this revision unless anyone has some other thoughts.
Feb 1 2018
@ngraham I tested it again just now with Breeze and Oxygen and both are OK.
@rizzitello I also use arch and I have this issue with the version you mention. The window opacity (on the opacity page of the qtcurve config dialog) has to be something less than 100% for this issue to show up.
Jan 31 2018
Jan 29 2018
@ngraham I think I will do that. Thanks!
Jan 28 2018
@ngraham Gladly. I wasn't sure if I can, being so new to this.
I think this is a good idea. Spectacle already remembers the last-used capture mode, delay, etc., and this would make remembering the save mode consistent with that by default.
Jan 27 2018
Submitting new revision.
@ngraham Thanks Nathaniel!
@ngraham So should I submit this new patch as a new revision? I'm still new to this.
@ngraham This is in addition to the last patch, Nate. It needs both, and this diff is off the current state of the repo. When I first looked into this, I tried setting ScaleType but it had no effect. Then I found that the preview image was being scaled based on the small vertical height that was being requested, which led to the first patch. I should have tried setting ScaleType again.
See my comment with the new patch.
I'm sorry for all the trouble, but I found the way to produce really clear previews.
Jan 21 2018
@davidedmundson Thanks for the commit!
Jan 20 2018
I'm new to phabricator and do not have commit access. Does someone need to commit this?
@broulik I'm new to phabricator and do not have commit access. Please commit for me. Thanks.
Jan 17 2018
After reviewing the kio commit where similar changes were made, I changed QFile::exists to QFileInfo::exists as was done in kio and have updated my patch. I should have looked at kio before my first submission. Sorry.