| rkflx | |
| rkron |
| Spectacle |
BUG: 389614
Yet more anecdotal evidence from bug triaging suggests that many would prefer "Save As" to be the default save mode in Spectacle. This patch accomplishes that.
I am planning a larger rewrite of the buttons sometime in the coming weeks that should hopefully end squabbles over button settings, but until then, I believe this will be a welcome improvement.
Tested in KDE Neon
| No Linters Available |
| No Unit Test Coverage |
Good job. Extensive smartphone users used to not being prompted for a filename might be a bit annoyed by this, but unless autosave is rolled out for all of our software I'd value consistency higher.
Code LGTM.
Did you check whether we'd need any docbook alterations? I think we'll do because the default behaviour is explained quite prominently. (Sadly this would need to be changed again with a bigger rewrite, but IMO half-finished patches are to be avoided if we want to keep the quality up. You could also wait whether the bigger rewrite makes it in time for 18.04, but please don't leave it hanging in the end.)
| src/Gui/KSMainWindow.cpp | ||
|---|---|---|
| 204 | By renumbering you'll switch around modes even for users who explicitly chose something else and made it stick. Unfortunately, Spectacle saves the last mode even if it is the default (other apps don't do that), so changing defaults means either users losing their changes or users who started Spectacle at least once not getting the new default. I guess your approach is the lesser evil, but it's not ideal indeed. | |
| 326 | @rkron Looking at how ints are used here instead of enums hurts so much. It's an opportunity for some refactoring, getting to know Spectacle's codebase a bit… ;) | |
Regarding my comment in D10153#197608 and your bigger rewrite plans, let's discuss this in T7841.
Thanks, Henrik. Docbook changes are in D10204: Update Spectacle docbook to reflect recent changes