Feed Advanced Search

Yesterday

ognarb awarded T10120: Nextcloud plugin for server-side extraction a Love token.
Fri, Jan 17, 11:37 PM · KDE Itinerary
vkrause moved T10120: Nextcloud plugin for server-side extraction from Ideas to Done on the KDE Itinerary board.
Fri, Jan 17, 8:15 PM · KDE Itinerary
vkrause added a comment to T10120: Nextcloud plugin for server-side extraction.

Done: https://nextcloud.com/blog/the-new-standard-in-on-premises-team-collaboration-nextcloud-hub/ :)

Fri, Jan 17, 8:15 PM · KDE Itinerary

Thu, Jan 16

vkrause requested review of D26713: Adapt to Qt 5.14 Android changes.
Thu, Jan 16, 5:47 PM · Frameworks
vkrause committed R1007:5585caf17c87: Fix finding of some of the optional dependencies (authored by vkrause).
Fix finding of some of the optional dependencies
Thu, Jan 16, 5:45 PM
vkrause added a comment to T8793: Add data retrieval from the Akonadi calendar.

Definitely. This task just predates the work in D24443.

Thu, Jan 16, 9:06 AM · KDE Itinerary

Wed, Jan 15

vkrause committed R1003:2baa8d486164: Install translations when fetching them during the build (authored by vkrause).
Install translations when fetching them during the build
Wed, Jan 15, 6:02 PM
vkrause committed R1032:3025b8cbcb47: Fix build with Android NDK r20 (authored by vkrause).
Fix build with Android NDK r20
Wed, Jan 15, 5:54 PM
vkrause committed R1003:6b4685b46ff7: Allow to generate iCal output from the cli extractor directly (authored by vkrause).
Allow to generate iCal output from the cli extractor directly
Wed, Jan 15, 3:23 PM
vkrause committed R1003:60575befb677: Fix build without Poppler (authored by vkrause).
Fix build without Poppler
Wed, Jan 15, 3:23 PM

Tue, Jan 14

vkrause committed R849:77f99f54bc3d: Proceed with deletion operations even if parts of it fail, or weren't done (authored by vkrause).
Proceed with deletion operations even if parts of it fail, or weren't done
Tue, Jan 14, 7:23 PM
vkrause closed D26563: Proceed with deletion operations even if parts of it fail, or weren't done.
Tue, Jan 14, 7:23 PM
vkrause committed R1007:a548bd1dec62: Polish text wraping/eliding in the public transport backend page (authored by vkrause).
Polish text wraping/eliding in the public transport backend page
Tue, Jan 14, 6:14 PM
vkrause committed R1032:ea8013d828fd: Add Entur attribution information (authored by vkrause).
Add Entur attribution information
Tue, Jan 14, 5:48 PM
vkrause committed R1032:958b3a1fd776: Allow backends to configure extra HTTP headers (authored by vkrause).
Allow backends to configure extra HTTP headers
Tue, Jan 14, 5:48 PM
vkrause committed R1032:4fd8a3060016: Implement location queries for Entur (authored by vkrause).
Implement location queries for Entur
Tue, Jan 14, 5:48 PM
vkrause accepted D26569: Provide a way to easily query which feedback options are available.

Ah ok, all good then :) Thanks!

Tue, Jan 14, 12:14 PM

Mon, Jan 13

vkrause accepted D26577: Port KRecursiveFilterProxyModel to QSortFilterProxyModel.

Thanks for investigating this!

Mon, Jan 13, 3:57 PM

Sun, Jan 12

vkrause committed R1032:92972eb153ec: Set up OTP resources in static builds correctly (authored by vkrause).
Set up OTP resources in static builds correctly
Sun, Jan 12, 4:05 PM
vkrause committed R1032:d8d4b4d2608a: Support Entur departure queries (authored by vkrause).
Support Entur departure queries
Sun, Jan 12, 4:05 PM
vkrause committed R1032:b20d4d8523e7: Start to support the Entur variant of OTP (authored by vkrause).
Start to support the Entur variant of OTP
Sun, Jan 12, 1:31 PM
vkrause added a comment to D26551: Revise title and description texts for the different modes.

Thanks, that works for me. +1 on this then.

Sun, Jan 12, 11:08 AM
vkrause added a comment to D26569: Provide a way to easily query which feedback options are available.
In D26569#592135, @apol wrote:

See https://phabricator.kde.org/D26570, we definitely want translations. Should we use the description instead?

Sun, Jan 12, 11:06 AM
vkrause committed R296:3489a1d049fb: Port away from deprecated IconSize() method (authored by vkrause).
Port away from deprecated IconSize() method
Sun, Jan 12, 11:06 AM
vkrause closed D26603: Port away from deprecated IconSize() method.
Sun, Jan 12, 11:05 AM · Frameworks
vkrause added a comment to D26057: Deprecate the top-level IconSize() function.

Please port kdeclarative.

kdeclarative/private/kiconprovider.cpp:44:56: error: ‘IconSize’ was not declared in this scope

pixmap = QIcon::fromTheme(source.at(0)).pixmap(IconSize(KIconLoader::Desktop));

Detected by http://www.davidfaure.fr/2020/542.diff (to be applied to kdeclarative)

Thanks.

Sun, Jan 12, 10:59 AM · Frameworks
vkrause requested review of D26603: Port away from deprecated IconSize() method.
Sun, Jan 12, 10:58 AM · Frameworks

Sat, Jan 11

vkrause committed R1032:82a22cf08083: Parse timezone information from OTP responses if available (authored by vkrause).
Parse timezone information from OTP responses if available
Sat, Jan 11, 7:43 PM
vkrause committed R1032:6f73cb2fac7c: Support version 20170808 of the Digitransit OTP variant (authored by vkrause).
Support version 20170808 of the Digitransit OTP variant
Sat, Jan 11, 7:43 PM
vkrause committed R1032:3bfdc1d32659: Parse OTP line color information when available (authored by vkrause).
Parse OTP line color information when available
Sat, Jan 11, 4:09 PM
vkrause committed R1032:6d6d72945d99: Implement OTP alert parsing, and selecting the best language for those (authored by vkrause).
Implement OTP alert parsing, and selecting the best language for those
Sat, Jan 11, 3:36 PM
vkrause committed R1032:4b0845ce9c13: Deduplicate OTP location responses when searching by coordinates (authored by vkrause).
Deduplicate OTP location responses when searching by coordinates
Sat, Jan 11, 1:04 PM
vkrause committed R1032:8eb1a3ff86e5: Separate identifier namespaces for OTP backends (authored by vkrause).
Separate identifier namespaces for OTP backends
Sat, Jan 11, 1:04 PM
vkrause committed R1032:a5a1ccaef5ef: Integrate OTP location query result parsing (authored by vkrause).
Integrate OTP location query result parsing
Sat, Jan 11, 1:04 PM
vkrause committed R1032:37970be94412: Activate OTP backend (authored by vkrause).
Activate OTP backend
Sat, Jan 11, 1:04 PM
vkrause committed R1032:deda5edd790a: Implement OTP location query response parsing (authored by vkrause).
Implement OTP location query response parsing
Sat, Jan 11, 1:04 PM
vkrause added a comment to D26551: Revise title and description texts for the different modes.

Thanks! Maybe "KDE" -> "us", to keep the vendor-neutral wording, as this is also used outside of KDE. I'm ok with the rest of the wording changes.

Sat, Jan 11, 11:35 AM
vkrause added a comment to D26569: Provide a way to easily query which feedback options are available.

I'm fine with the interface, but I'm unsure whether this is human or machine read? For human consumption we might want translated texts?

Sat, Jan 11, 11:30 AM
vkrause added a comment to D26563: Proceed with deletion operations even if parts of it fail, or weren't done.
In D26563#591734, @apol wrote:

+1
This makes sense, it's possibly what happened. I'm not sure how I made it happen though.

So it failed this bad because I added a wrong column?

Sat, Jan 11, 11:23 AM
vkrause added a comment to D26577: Port KRecursiveFilterProxyModel to QSortFilterProxyModel.

With the infinite recursion fixed this seems to produce correct results, but the search performance in the size view is now massively worse.

Sat, Jan 11, 11:19 AM

Fri, Jan 10

vkrause added a comment to T12520: Qt 5.14.

As there seems to be little documentation about those changes, the following Qt git revisions are relevant:

  • c8b07f7da3ff55f92378a1e98522f318bbc43077 (qtbase)
  • 5bb178c479a247720fbc3fbb7f06a32b725193ac (qtbase)
  • 670fdcc3f23493bc039a2676ce69892cc152dc6b (qtdeclarative)
Fri, Jan 10, 5:47 PM · Android
vkrause triaged T12520: Qt 5.14 as Normal priority.
Fri, Jan 10, 5:40 PM · Android
vkrause committed R1032:fac270c8a0e2: Fix ISO 3166-2 codes for UK Traveline and Railteam (authored by vkrause).
Fix ISO 3166-2 codes for UK Traveline and Railteam
Fri, Jan 10, 4:58 PM
vkrause committed R1007:bce80d587294: Show section headers in the public transport backend page (authored by vkrause).
Show section headers in the public transport backend page
Fri, Jan 10, 4:57 PM
vkrause committed R1032:d1db957a9541: Handle realtime data for OTP journey results too (authored by vkrause).
Handle realtime data for OTP journey results too
Fri, Jan 10, 4:42 PM
vkrause committed R1032:2b7cfca24859: Expose backend primary country code (authored by vkrause).
Expose backend primary country code
Fri, Jan 10, 4:42 PM
vkrause committed R1032:be7b7a9d6a9b: Parse OTP realtime departure times (authored by vkrause).
Parse OTP realtime departure times
Fri, Jan 10, 4:42 PM
vkrause requested review of D26563: Proceed with deletion operations even if parts of it fail, or weren't done.
Fri, Jan 10, 4:36 PM
vkrause added a comment to D26551: Revise title and description texts for the different modes.

Yeah, the idea behind this change was that the parent UI presenting these strings would include the explanation.

Does the standalone dialog live in this repo?

Fri, Jan 10, 4:21 PM
vkrause triaged T12519: Allow to use the current location as a starting point for a transfer element as Wishlist priority.
Fri, Jan 10, 4:10 PM · KDE Itinerary
vkrause triaged T12518: Support more than one favorite/"home" location for transfer elements as Wishlist priority.
Fri, Jan 10, 4:10 PM · KDE Itinerary
vkrause added a comment to D26551: Revise title and description texts for the different modes.

I think the stand-alone app case (as seen in the second video) now misses the motivational explanation for why we do this, in the Plasma KCM this is added independently. Maybe just add that sentence to the top of the default config dialog?

Fri, Jan 10, 8:24 AM

Thu, Jan 9

vkrause committed R1032:e1b060ca8305: Add unit test for the OTP parser (authored by vkrause).
Add unit test for the OTP parser
Thu, Jan 9, 6:11 PM
vkrause committed R1032:fae242ee5503: Add mapping function from extended GTFS route types to our line types (authored by vkrause).
Add mapping function from extended GTFS route types to our line types
Thu, Jan 9, 6:11 PM
vkrause committed R1032:c6958db8524f: Get started on parsing OTP replies (authored by vkrause).
Get started on parsing OTP replies
Thu, Jan 9, 6:11 PM
vkrause committed R1032:035fe3f24415: Implement the remaining journey query parameters (authored by vkrause).
Implement the remaining journey query parameters
Thu, Jan 9, 6:11 PM
vkrause committed R1032:807d05ba29eb: Generate departure queries based on coordinates, not station/stop ids (authored by vkrause).
Generate departure queries based on coordinates, not station/stop ids
Thu, Jan 9, 6:11 PM
vkrause committed R1032:5d3f7d9b6a2a: Implement logging support for OTP (authored by vkrause).
Implement logging support for OTP
Thu, Jan 9, 6:11 PM
vkrause accepted D26546: Remove unused include.
Thu, Jan 9, 5:21 PM · KDE PIM

Wed, Jan 8

vkrause added a comment to D26532: Don't use KWindowSystem on Android.

We are already not building a few things here on Android (including public API on other platforms), so excluding more is fine IMHO, especially if it's stuff where you can't argue an empty stub is a useful porting aid.

IIRC the case with KSNI on Android was a bit different since it never was part of the ABI on Android, whereas KPassivePopup is.

Wed, Jan 8, 9:49 PM · Frameworks
vkrause accepted D26532: Don't use KWindowSystem on Android.

We are already not building a few things here on Android (including public API on other platforms), so excluding more is fine IMHO, especially if it's stuff where you can't argue an empty stub is a useful porting aid.

Wed, Jan 8, 8:33 PM · Frameworks
vkrause committed R1032:f7c6b60453a2: Don't wrongly emit finished() when having cache hits and pending ops (authored by vkrause).
Don't wrongly emit finished() when having cache hits and pending ops
Wed, Jan 8, 8:19 PM
vkrause committed R1032:d1eb9876fb68: Add OpenTripPlanner backend stub (authored by vkrause).
Add OpenTripPlanner backend stub
Wed, Jan 8, 8:19 PM
vkrause committed R1032:bb39a5e90aff: Move library content into its own sub-folder (authored by vkrause).
Move library content into its own sub-folder
Wed, Jan 8, 6:00 PM
vkrause committed R1032:a91c9dc79c14: Add a tool to retrieve coverage bounding boxes from OTP endpoints (authored by vkrause).
Add a tool to retrieve coverage bounding boxes from OTP endpoints
Wed, Jan 8, 6:00 PM
vkrause committed R1032:8bd55e5464de: Adjust GraphQL coding style settings to match GraphiQL output (authored by vkrause).
Adjust GraphQL coding style settings to match GraphiQL output
Wed, Jan 8, 5:29 PM
vkrause committed R1032:ecda5ca23fb8: Add GraphQL queries for locations too (authored by vkrause).
Add GraphQL queries for locations too
Wed, Jan 8, 5:29 PM
vkrause committed R1032:ef5c189c570a: Adjust departure date to today for DB vehicle layout queries (authored by vkrause).
Adjust departure date to today for DB vehicle layout queries
Wed, Jan 8, 5:10 PM
vkrause committed R1032:8a7f5d210f42: Add forgotten file, sorry (authored by vkrause).
Add forgotten file, sorry
Wed, Jan 8, 7:29 AM

Tue, Jan 7

vkrause committed R1032:057bf30025f6: Add OpenTripPlanner GraphQL queries for departures/journeys (authored by vkrause).
Add OpenTripPlanner GraphQL queries for departures/journeys
Tue, Jan 7, 6:11 PM
vkrause committed R1032:cb6fa6af1b55: Add GraphQL client (authored by vkrause).
Add GraphQL client
Tue, Jan 7, 6:11 PM
vkrause committed R1007:a96ec1a0d98e: Position layout view on the selected vehicle section initially (authored by vkrause).
Position layout view on the selected vehicle section initially
Tue, Jan 7, 5:26 PM
vkrause committed R1032:35efdaeb9de9: Scroll layout view to the beginning of the vehicle (authored by vkrause).
Scroll layout view to the beginning of the vehicle
Tue, Jan 7, 5:22 PM
vkrause committed R1032:3aef8968567c: Add method to query position of a vehicle section (authored by vkrause).
Add method to query position of a vehicle section
Tue, Jan 7, 5:22 PM
vkrause committed R1032:d39c16b80b8f: Properly reset vehicle layout query model when running a new query (authored by vkrause).
Properly reset vehicle layout query model when running a new query
Tue, Jan 7, 5:22 PM
vkrause added a comment to D26428: Rely on QtWebEngine to determine the mimetype of http(s) URLs.

There is one major drawback with this plan though. There were talks about deprecating kio_http for security reasons... Adding Volker as reviewer.

Tue, Jan 7, 8:04 AM

Mon, Jan 6

vkrause moved T11380: Add support for OpenTripPlanner backends from Ideas to In Progress on the KPublicTransport board.
Mon, Jan 6, 8:59 PM · KPublicTransport
vkrause committed R1007:f253403741dd: Fix calendar imports for newer DavDroid versions (authored by vkrause).
Fix calendar imports for newer DavDroid versions
Mon, Jan 6, 8:23 PM
vkrause committed R216:e94fbd056539: Add GraphQL highlighting definition (authored by vkrause).
Add GraphQL highlighting definition
Mon, Jan 6, 7:53 PM
vkrause closed D26472: Add GraphQL highlighting definition.
Mon, Jan 6, 7:53 PM · Frameworks, Kate
vkrause requested review of D26472: Add GraphQL highlighting definition.
Mon, Jan 6, 6:56 PM · Frameworks, Kate
vkrause accepted D26471: Don't find KHTML.

Nice! I missed the about page got ported meanwhile :)

Mon, Jan 6, 5:40 PM
vkrause committed R1003:d7bc98d72935: Initial support for extracting VR (Finish railway) tickets (authored by vkrause).
Initial support for extracting VR (Finish railway) tickets
Mon, Jan 6, 5:36 PM
vkrause committed R1003:bd0aa8747684: Merge remote-tracking branch 'kde/release/19.12' (authored by vkrause).
Merge remote-tracking branch 'kde/release/19.12'
Mon, Jan 6, 5:17 PM
vkrause committed R1003:12cabf13ceea: Fix address extraction in NH Hotel booking confirmations (authored by vkrause).
Fix address extraction in NH Hotel booking confirmations
Mon, Jan 6, 5:14 PM
vkrause committed R1003:f2f996314602: Extract passenger name for Thalys tickets too (authored by vkrause).
Extract passenger name for Thalys tickets too
Mon, Jan 6, 5:13 PM
vkrause committed R1007:ffc5cb133bfa: Highlight the vehicle section that contains the reserved seat (authored by vkrause).
Highlight the vehicle section that contains the reserved seat
Mon, Jan 6, 5:08 PM
vkrause abandoned D26433: Attempt to fix the Windows build after 34fdee065da2ddd.
Mon, Jan 6, 8:51 AM · KDE PIM

Sun, Jan 5

vkrause committed R1003:bf77c46c7bba: Add Thalys ticket extractor (authored by vkrause).
Add Thalys ticket extractor
Sun, Jan 5, 2:03 PM
vkrause committed R1003:f1c80d03e2aa: Merge remote-tracking branch 'kde/release/19.12' (authored by vkrause).
Merge remote-tracking branch 'kde/release/19.12'
Sun, Jan 5, 2:03 PM
vkrause requested review of D26433: Attempt to fix the Windows build after 34fdee065da2ddd.
Sun, Jan 5, 1:02 PM · KDE PIM
vkrause committed R1018:46c806636c6b: Improve diagnostics for image loading (authored by vkrause).
Improve diagnostics for image loading
Sun, Jan 5, 12:14 PM
vkrause committed R1003:f101c17f8110: NH extractor: Be more robust against mangled HTML during forwarding (authored by vkrause).
NH extractor: Be more robust against mangled HTML during forwarding
Sun, Jan 5, 11:52 AM
vkrause added a comment to D26074: Port away from depreacted IconSize() method.

The stable branch "release/19.12" for kwalletmanager fails to build. Does this need to be backported for the coming 19.12.1 release?

Sun, Jan 5, 10:49 AM
vkrause committed R362:6f7ae97b22df: Do not use future versions for disabling deprecated API in stable branches (authored by vkrause).
Do not use future versions for disabling deprecated API in stable branches
Sun, Jan 5, 10:46 AM

Sat, Jan 4

vkrause committed R1007:b91639a35239: Initial integration of the train layout display (authored by vkrause).
Initial integration of the train layout display
Sat, Jan 4, 1:25 PM
vkrause committed R1032:9d5fa8383074: Attempt to fix high dpi vehicle section rendering (authored by vkrause).
Attempt to fix high dpi vehicle section rendering
Sat, Jan 4, 12:20 PM
vkrause committed R1007:6b291b64a426: Use the monochrome about icon for consistency in the main menu (authored by vkrause).
Use the monochrome about icon for consistency in the main menu
Sat, Jan 4, 10:33 AM
vkrause added a comment to D26393: Expand dynamic cast hierarchy..

I have a theory where this might come from, but I can't verify this here (problem is not reproduceable): KeyListModelInterface is in a different lib and is not exported (all inline), but has a vtable and RTTI data. This results in the RTTI data being duplicated in every lib/executable (as there is no exported one that can be shared), which means there's two different RTTI instances for the kleo binary and libkleo, dynamic_cast picks the wrong one in your setup, and fails. The second level cast to KeyRearrangeColumnsProxyModel (in libkleo, but exported) makes it cast from a type in the same lib, which then apparently makes it pick the right RTTI instance and succeed.

Sat, Jan 4, 10:19 AM · KDE PIM
vkrause added a comment to T12186: Purpose: Platform support.

Isn't this exactly the platform abstraction vs. platform implementation conflict? Ie. can (or should) Purpose cover both sides of this? If not, we probably want something separate doing the platform abstraction, with Purpose providing the implementation on the Plasma platform (and others not having their own implementation, probably).

Sat, Jan 4, 10:00 AM · KF6