Create Task
Maniphest T12722

Drop KDBusConnectionPool
Open, Needs TriagePublic
Actions

Description

Since c2049f67e4cfe5f09e1b033b910cb37d043a287e in qtbase all underlying DBus stuff was moved into it's own dedicated DBus thread

KDBusConnectionPool was made before then.

QDBusConnection/QDBusConnectionInterface are very thin wrappers that dispatch into the shared dedicated thread. The creating factory,QDBusConnectionManager looks thread safe, it's certainly trying to do things.

I think there's a very very strong possibility whatever we were working around is not relevant anymore, but it requires input from whoever made this class.

Related Objects

vkrause added a subscriber: vkrause.Feb 18 2020, 8:54 PM

This was added as using QDBusConnection from different threads at the same time wasn't supported, you needed one QDBusConnection instance per thread. IIRC that was the only reason for having this.

davidedmundson added a comment.EditedFeb 18 2020, 9:31 PM

Right, but do you agree that using a QDBusConnection from different threads now is supported?

vkrause added a subscriber: thiago.Feb 18 2020, 9:47 PM

Seems like it, but I haven't tried anymore since getting burned on this prior to the creation of KDBusConnectionPool :D
@thiago would probably be able to answer this for sure?

thiago added a comment.Feb 18 2020, 10:25 PM

Yes, it's been supported for years.

davidedmundson renamed this task from KDBusConnectionPool: is it still needed? to Drop KDBusConnectionPool.Feb 18 2020, 10:33 PM
davidedmundson moved this task from Needs Input to Waiting on KF6 Branching on the KF6 board.
dfaure added a subscriber: dfaure.Sep 10 2020, 9:47 AM

https://lxr.kde.org/ident?_i=KDBusConnectionPool&_remember=1 says everything was ported away from KDBusConnectionPool, good job :-)

vkrause moved this task from Waiting on KF6 Branching to Done on the KF6 board.Jan 29 2023, 2:45 PM