Create Task
Maniphest T12210

Port KIO DavJob away from QDomDocument in the public API
Open, Needs TriagePublic
Actions

Description

KIOCORE_EXPORT DavJob *davPropFind(const QUrl &url, const QDomDocument &properties, const QString &depth, JobFlags flags = KIOCORE_EXPORT DavJob *davPropPatch(const QUrl &url, const QDomDocument &properties, JobFlags flags = DefaultFlags);
dfaure created this task.Nov 24 2019, 10:22 AM
dfaure added a comment.Sep 8 2020, 4:22 PM

QDomDocument won't be deprecated after all, so we can forget this IMHO.

dfaure removed a project: KF6.Sep 8 2020, 4:34 PM
vkrause added a comment.Sep 9 2020, 12:24 PM

AFAIK this is the only place in KIO pulling QtXml into the public link interface, and as such also forcing QDom* on the consumer, instead of any of the more efficient XML APIs. IMHO still worth using the opportunity of the ABI break to address this, IIRC this is a fairly straightforward qdom -> string change, but you are right of course that this moved from essential to nice to have.

dfaure added a project: KF6.Sep 9 2020, 12:27 PM

OK, fair point, putting the task back onto the board ;)

alex moved this task from Backlog to Waiting on KF6 Branching on the KF6 board.Aug 12 2021, 3:30 PM
ahmadsamir added a subscriber: ahmadsamir.Dec 8 2021, 8:05 PM

Posting here so as not to forget; QDomDocument is still used in the implementation of KIO::davSearch().

vkrause moved this task from Waiting on KF6 Branching to Done on the KF6 board.Jan 31 2023, 6:02 PM