piotrkakol (Piotr Kąkol)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Feb 10 2018, 11:48 PM (40 w, 3 d)
Availability
Available

Recent Activity

Oct 1 2018

piotrkakol added a comment to D15876: Fix copyrights in binary clock files.

Well, previously it looked like I claimed to be contributor to fuzzy-clock, analog-clock and version from KDE4.
Now it's clear that I only contributed to the newest version of binary-clock.

Oct 1 2018, 1:01 PM · Plasma
piotrkakol requested review of D15876: Fix copyrights in binary clock files.
Oct 1 2018, 12:12 PM · Plasma

Sep 5 2018

piotrkakol added a comment to D14384: Renamed dot to square in variables and filenames.

Yes, but I forgeted to put them in the last diff. Do I really have to make a separate diff to change it?

Sep 5 2018, 1:58 PM · Plasma
piotrkakol added a comment to D14384: Renamed dot to square in variables and filenames.

I did change main.qml as you can see here:
https://phabricator.kde.org/R114:9eae090a3038ebf97ffeee8c9b773a8610e13021

Sep 5 2018, 1:49 PM · Plasma
piotrkakol added a comment to D14384: Renamed dot to square in variables and filenames.

Ping.

Sep 5 2018, 1:09 PM · Plasma

Jul 25 2018

piotrkakol requested review of D14384: Renamed dot to square in variables and filenames.
Jul 25 2018, 8:53 PM · Plasma
piotrkakol requested review of D14377: Changed variable type to int to display squares instead of rectangles.
Jul 25 2018, 3:58 PM · Plasma

Jul 23 2018

piotrkakol requested review of D14307: Changed refresh time from 30 to 60 seconds.
Jul 23 2018, 6:32 PM · Plasma
piotrkakol abandoned D14306: Changed refresh time from 30 to 60 seconds.
Jul 23 2018, 5:55 PM · Plasma
piotrkakol requested review of D14306: Changed refresh time from 30 to 60 seconds.
Jul 23 2018, 5:53 PM · Plasma

Jul 21 2018

piotrkakol abandoned D14268: Changed refresh time from 30 to 60 seconds.
Jul 21 2018, 10:38 PM · Plasma
piotrkakol added a comment to D14268: Changed refresh time from 30 to 60 seconds.

Thanks, David.
Yeah, even though I followed the instructions you can see that the branch in this diff is "change-refresh-time (branched from master)" and it should be "change-refresh-time (branched from code-cleanup)".
I'll remove this diff and try to make another one from the correct branch on Monday, with the line you requested.

Jul 21 2018, 10:24 PM · Plasma
piotrkakol requested review of D14268: Changed refresh time from 30 to 60 seconds.
Jul 21 2018, 10:06 PM · Plasma
piotrkakol requested review of D14267: Cleaned code for binary clock applet and added comments.
Jul 21 2018, 9:06 PM · Plasma

Jul 20 2018

piotrkakol added a comment to D13937: Update formulas and add option to change grid thickness.

Thanks for the link! I'll check it out probably tomorrow and will make new diff(s). :-)

Jul 20 2018, 3:25 PM · Plasma
piotrkakol added a comment to D13937: Update formulas and add option to change grid thickness.

Thanks. It can be breaked into smaller pieces. In fact, these 6 lines in the summary are titles of my commits that artisan combined into 1 diff.
This is why Phabricator is quite inconvenient. On GitHub you can have multiple commits in one Pull Request (diff equivalent), committer doesn't need to have merge rights, so a repo maintainer who has merges the PR.
E.g. here there are 2 commits in 1 PR.
Here I can't make commits - only diffs. And from what I understand 1 diff should be 1 commit. So do I really need to make 1 diff for the 1st commit, then wait for it to be merged, add 2nd diff, etc. up to 6th diff/commit? I could make 6 diffs now but some of them would have to include changes from other diffs. And I don't know if diffs can have parents.

Jul 20 2018, 3:09 PM · Plasma

Jul 7 2018

piotrkakol added a comment to D13937: Update formulas and add option to change grid thickness.

I don't have KDE developer account so I cannot push this patch.

Jul 7 2018, 11:20 PM · Plasma
piotrkakol added a comment to D13937: Update formulas and add option to change grid thickness.


On the left there's the old applet and on the right mine after only changing dotSize (now squareSize) from real to int. All squares, not rectangles.

Jul 7 2018, 10:45 PM · Plasma
piotrkakol requested review of D13937: Update formulas and add option to change grid thickness.
Jul 7 2018, 10:27 PM · Plasma

Mar 7 2018

piotrkakol added a comment to D10434: Allow users to change the format to BCD (decimal) in Binary Clock widget.

I was instructed to give my contact details that will be included in the commit message.
Piotr Kąkol piotrkakol@pm.me

Mar 7 2018, 2:46 PM · Plasma

Feb 19 2018

piotrkakol added a comment to D10434: Allow users to change the format to BCD (decimal) in Binary Clock widget.

Thank you for reviewing.

Feb 19 2018, 4:54 PM · Plasma

Feb 12 2018

piotrkakol updated the diff for D10434: Allow users to change the format to BCD (decimal) in Binary Clock widget.

Instead of changing the base to decimal I decided to allow users to choose between base 10 (BCD format) and 16 (sexagesimal format) in the config.

Feb 12 2018, 8:19 PM · Plasma

Feb 11 2018

piotrkakol updated the summary of D10434: Allow users to change the format to BCD (decimal) in Binary Clock widget.
Feb 11 2018, 12:10 AM · Plasma
piotrkakol updated the summary of D10434: Allow users to change the format to BCD (decimal) in Binary Clock widget.
Feb 11 2018, 12:05 AM · Plasma
piotrkakol requested review of D10434: Allow users to change the format to BCD (decimal) in Binary Clock widget.
Feb 11 2018, 12:02 AM · Plasma