- User Since
- Feb 10 2018, 11:48 PM (87 w, 6 d)
Oct 1 2018
Well, previously it looked like I claimed to be contributor to fuzzy-clock, analog-clock and version from KDE4.
Now it's clear that I only contributed to the newest version of binary-clock.
Sep 5 2018
Yes, but I forgeted to put them in the last diff. Do I really have to make a separate diff to change it?
I did change main.qml as you can see here:
Jul 25 2018
Jul 23 2018
Jul 21 2018
Yeah, even though I followed the instructions you can see that the branch in this diff is "change-refresh-time (branched from master)" and it should be "change-refresh-time (branched from code-cleanup)".
I'll remove this diff and try to make another one from the correct branch on Monday, with the line you requested.
Jul 20 2018
Thanks for the link! I'll check it out probably tomorrow and will make new diff(s). :-)
Thanks. It can be breaked into smaller pieces. In fact, these 6 lines in the summary are titles of my commits that artisan combined into 1 diff.
This is why Phabricator is quite inconvenient. On GitHub you can have multiple commits in one Pull Request (diff equivalent), committer doesn't need to have merge rights, so a repo maintainer who has merges the PR.
E.g. here there are 2 commits in 1 PR.
Here I can't make commits - only diffs. And from what I understand 1 diff should be 1 commit. So do I really need to make 1 diff for the 1st commit, then wait for it to be merged, add 2nd diff, etc. up to 6th diff/commit? I could make 6 diffs now but some of them would have to include changes from other diffs. And I don't know if diffs can have parents.
Jul 7 2018
I don't have KDE developer account so I cannot push this patch.
On the left there's the old applet and on the right mine after only changing dotSize (now squareSize) from real to int. All squares, not rectangles.
Mar 7 2018
I was instructed to give my contact details that will be included in the commit message.
Piotr Kąkol firstname.lastname@example.org
Feb 19 2018
Thank you for reviewing.
Feb 12 2018
Instead of changing the base to decimal I decided to allow users to choose between base 10 (BCD format) and 16 (sexagesimal format) in the config.