Add minimal number of moves statistics
Needs ReviewPublic

Authored by piotrkakol on Sun, Dec 1, 1:10 AM.

Details

Reviewers
None
Group Reviewers
KDE Games
Summary

Statistics that displays the minimal number of moves that a player used to win a game. This could be used to make the game more competitive - comparing your score to other people's.

The number is set to -1 (which is unachievable) when reseting the statistics and an infinity symbol is then displayed.

Diff Detail

Repository
R410 KPatience
Lint
Lint Skipped
Unit
Unit Tests Skipped
piotrkakol created this revision.Sun, Dec 1, 1:10 AM
Restricted Application added a reviewer: KDE Games. · View Herald TranscriptSun, Dec 1, 1:10 AM
Restricted Application added a subscriber: kde-games-devel. · View Herald Transcript
piotrkakol requested review of this revision.Sun, Dec 1, 1:10 AM
piotrkakol edited the summary of this revision. (Show Details)Sun, Dec 1, 1:15 AM
aacid added a subscriber: aacid.Sun, Dec 1, 9:53 PM
aacid added inline comments.
statisticsdialog.cpp
125

Shouldn't that 0 be -1 ?

Otherwise for already recorded stats you'll get a 0, no?

piotrkakol updated this revision to Diff 70710.Mon, Dec 2, 12:26 AM

Changed the default value set to minmoves from 0 to -1 thanks to aacid's comment.

aacid added inline comments.Mon, Dec 2, 11:21 PM
dealer.cpp
1751

shouldn't this be -1 too?

piotrkakol updated this revision to Diff 70827.Tue, Dec 3, 2:26 PM
piotrkakol marked an inline comment as done.
aacid added a comment.Mon, Dec 9, 10:08 PM

Can you confirmed you've actually tried this?

Because i found 2 places where if you would have tried it, it would have not worked, so i'm a bit puzzled as to how much testing this patch got at all