In D29845#674882, @mart wrote:please use gitlab on invent.kde.org for new review requests
- Queries
- All Stories
- Search
- Advanced Search
Feed Advanced Search
Advanced Search
Advanced Search
Jun 21 2020
Jun 21 2020
Jun 8 2020
Jun 8 2020
Jun 4 2020
Jun 4 2020
@ngraham It does scale smooth-ish-ly according to taskbar size. You can see that square size (dotSize in BinaryClock.qml) is calculated based on taskbar size (height for horizontal taskbar and width for vertical taskbar). When you change taskbar size, binary clock changes size as well.
This is probably the last diff from my initial Binary Clock rework from D13937.
If you have any ideas what else can be improved after these changes, please let me know.
Jun 3 2020
Jun 3 2020
May 24 2020
May 24 2020
Dec 18 2019
Dec 18 2019
Yes, I have tried it. At first I just launched the game and checked if the functionality worked. After your last comment I deleted all files and checked all scenarios I could think of from the start. I'm sorry that I didn't do it before I submitted this diff. I didn't think about the initial state of the game.
Dec 3 2019
Dec 3 2019
Dec 2 2019
Dec 2 2019
Changed the default value set to minmoves from 0 to -1 thanks to aacid's comment.
Dec 1 2019
Dec 1 2019
Oct 1 2018
Oct 1 2018
Well, previously it looked like I claimed to be contributor to fuzzy-clock, analog-clock and version from KDE4.
Now it's clear that I only contributed to the newest version of binary-clock.
Sep 5 2018
Sep 5 2018
Yes, but I forgeted to put them in the last diff. Do I really have to make a separate diff to change it?
I did change main.qml as you can see here:
https://phabricator.kde.org/R114:9eae090a3038ebf97ffeee8c9b773a8610e13021
Ping.
Jul 25 2018
Jul 25 2018
piotrkakol requested review of D14377: Changed variable type to int to display squares instead of rectangles.
Jul 23 2018
Jul 23 2018
Jul 21 2018
Jul 21 2018
Thanks, David.
Yeah, even though I followed the instructions you can see that the branch in this diff is "change-refresh-time (branched from master)" and it should be "change-refresh-time (branched from code-cleanup)".
I'll remove this diff and try to make another one from the correct branch on Monday, with the line you requested.
Jul 20 2018
Jul 20 2018
Thanks for the link! I'll check it out probably tomorrow and will make new diff(s). :-)
Thanks. It can be breaked into smaller pieces. In fact, these 6 lines in the summary are titles of my commits that artisan combined into 1 diff.
This is why Phabricator is quite inconvenient. On GitHub you can have multiple commits in one Pull Request (diff equivalent), committer doesn't need to have merge rights, so a repo maintainer who has merges the PR.
E.g. here there are 2 commits in 1 PR.
Here I can't make commits - only diffs. And from what I understand 1 diff should be 1 commit. So do I really need to make 1 diff for the 1st commit, then wait for it to be merged, add 2nd diff, etc. up to 6th diff/commit? I could make 6 diffs now but some of them would have to include changes from other diffs. And I don't know if diffs can have parents.
Jul 7 2018
Jul 7 2018
I don't have KDE developer account so I cannot push this patch.
On the left there's the old applet and on the right mine after only changing dotSize (now squareSize) from real to int. All squares, not rectangles.
Mar 7 2018
Mar 7 2018
piotrkakol added a comment to D10434: Allow users to change the format to BCD (decimal) in Binary Clock widget.
I was instructed to give my contact details that will be included in the commit message.
Piotr Kąkol piotrkakol@pm.me
Feb 19 2018
Feb 19 2018
piotrkakol added a comment to D10434: Allow users to change the format to BCD (decimal) in Binary Clock widget.
Thank you for reviewing.
Feb 12 2018
Feb 12 2018
piotrkakol updated the diff for D10434: Allow users to change the format to BCD (decimal) in Binary Clock widget.
Instead of changing the base to decimal I decided to allow users to choose between base 10 (BCD format) and 16 (sexagesimal format) in the config.
Feb 11 2018
Feb 11 2018
piotrkakol updated the summary of D10434: Allow users to change the format to BCD (decimal) in Binary Clock widget.
piotrkakol updated the summary of D10434: Allow users to change the format to BCD (decimal) in Binary Clock widget.