Renamed dot to square in variables and filenames
Needs RevisionPublic

Authored by piotrkakol on Jul 25 2018, 8:53 PM.

Details

Reviewers
davidedmundson

Diff Detail

Repository
R114 Plasma Addons
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 1194
Build 1207: arc lint + arc unit
piotrkakol created this revision.Jul 25 2018, 8:53 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJul 25 2018, 8:53 PM
piotrkakol requested review of this revision.Jul 25 2018, 8:53 PM
davidedmundson requested changes to this revision.Sep 5 2018, 1:26 PM

this is putting big assumptions about the UI in the code and doesn't make things better.

applets/binary-clock/package/contents/ui/main.qml
3

you can't do this on files you didn't change

This revision now requires changes to proceed.Sep 5 2018, 1:26 PM
zzag added a subscriber: zzag.Sep 5 2018, 1:57 PM

w.r.t. this patch, those 2 copyright changes look really unrelated.

piotrkakol added a comment.EditedSep 5 2018, 1:58 PM

Yes, but I forgeted to put them in the last diff. Do I really have to make a separate diff to change it?

Edit: My bad. I putted the copyrights. It's just they were in the wrong place. So I just cleared it up a bit. Seems even less reason to make a separate diff for it. It's just formatting.