Differential D14268

Changed refresh time from 30 to 60 seconds
AbandonedPublic
Actions

Authored by piotrkakol on Jul 21 2018, 10:06 PM.

Details

Reviewers: None

Diff Detail

Repository

R114 Plasma Addons

Branch

change-refresh-time (branched from master)

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 1057
Build 1070: arc lint + arc unit

piotrkakol created this revision.Jul 21 2018, 10:06 PM

Restricted Application added a project: Plasma. · View Herald TranscriptJul 21 2018, 10:06 PM

piotrkakol requested review of this revision.Jul 21 2018, 10:06 PM

Harbormaster completed remote builds in B1057: Diff 38189.Jul 21 2018, 10:06 PM

also try to commit just the change you're making not all of the other changes in the other commit

applets/binary-clock/package/contents/ui/main.qml
51	please add intervalAlignment: plasmoid.configuration.showSeconds ? PlasmaCore.Types.NoAlignment : PlasmaCore.Types.AlignToMinute

Thanks, David.
Yeah, even though I followed the instructions you can see that the branch in this diff is "change-refresh-time (branched from master)" and it should be "change-refresh-time (branched from code-cleanup)".
I'll remove this diff and try to make another one from the correct branch on Monday, with the line you requested.

piotrkakol abandoned this revision.Jul 21 2018, 10:38 PM

Revision Contents
Changeset List

			Path	Packages
M			applets/binary-clock/package/contents/config/config.qml (3 lines)
M			applets/binary-clock/package/contents/config/main.xml (3 lines)
M			applets/binary-clock/package/contents/ui/BinaryClock.qml (105 lines)
M			applets/binary-clock/package/contents/ui/Dot.qml (46 lines)
M			applets/binary-clock/package/contents/ui/DotColumn.qml (38 lines)
M			applets/binary-clock/package/contents/ui/configGeneral.qml (6 lines)
M			applets/binary-clock/package/contents/ui/main.qml (10 lines)
M			applets/binary-clock/package/metadata.desktop (4 lines)

Commit	Tree	Parents	Author	Summary	Date
6485ac2e4924	47457838b815	7d87c930dd24	Piotr Kąkol	Changed refresh time from 30 to 60 seconds	Jul 21 2018, 7:54 PM
7d87c930dd24	5330c808575e	8713b5001aee	Piotr Kąkol	Cleaned code for binary clock applet and added comments	Jul 21 2018, 7:50 PM