Make "Disk Usage window" a regular window (if this takes too long, make it a modal window)
Closed, ResolvedPublic

Description

Looking at the code: the window of Konfigurator was supposed to be modal. I'll attach a patch.


But here comes a question: Would it be better if the Disk Usage window was modal?

The Disk Usage tool is available, for example, clicking in the

Tool > Disk Usage tool

menu and then clicking the OK button. But nowadays there are problems when minimizing the Disk Usage window.

If the Disk Usage window was modal, a simple setWindowModality(Qt::WindowModal); would solve the current situation.

But if the Disk Usage window is not modal, like nowadays, then one solution would have to be given to the problem of minimizing the Disk Usage window, because then that window is no longer seen, not even in the taskbar; until the user does something not intuitive like e.g. minimizing the main window of Krusader and later maximizing it.

Details

asensi created this task.Mar 30 2016, 10:58 PM

My opinion: Disk Usage window should be a regular window (like text editor - F3/F4). So user has the option to see more then one Disk Usage windows at the same time.

The current state is kind of half-way there. It is possible to see more then one Disk Usages but it is not a regular window.

But if it would be too difficult to rework, I'm fine with modal dialog.

asensi renamed this task from Make some windows modal to Make "Disk Usage window" a regular window (if this takes too long, make it a modal window).Apr 9 2016, 12:29 PM
asensi removed asensi as the assignee of this task.
asensi edited subscribers, added: Krusader; removed: martinkostolny, asensi.

My opinion: Disk Usage window should be a regular window (like text editor - F3/F4). So user has the option to see more
then one Disk Usage windows at the same time.

The current state is kind of half-way there. It is possible to see more then one Disk Usages but it is not a regular window.

But if it would be too difficult to rework, I'm fine with modal dialog.

I think the same, now the window of Konfigurator is modal, and the "Disk Usage window" should be a regular window (but if that takes too long, make it a modal window).

My opinion: Disk Usage window should be a regular window (like text editor - F3/F4). So user has the option to see more then one Disk Usage windows at the same time.

The current state is kind of half-way there. It is possible to see more then one Disk Usages but it is not a regular window.

But if it would be too difficult to rework, I'm fine with modal dialog.

Hello,

I'm pretty new with Qt/KDE development but like to start contributing to this project.
I'm not so pretty sure what is meant with "regular window" but I assume that the window should remain as is an just appear in the task bar.
I have changed the dialog to be non-modal and connected it to the close slot of Qdialog (please refer to the attached patch file).

As I wrote, I'm pretty new with Qt development, please don't hesitate to review/comment the changes.
I hope it helps a bit.

regards
{F3802002}Miroslav

abika added a subscriber: abika.Jul 2 2017, 4:13 PM

@miroslavm Please submit the patch as differential (== review request) and link it to this task (if this is somehow possible).

abika moved this task from TODO to In progress on the Krusader board.Jul 6 2017, 6:13 PM
asensi closed this task as Resolved.Jul 23 2017, 11:43 AM

The improvement seems to work nicely (tried using Kubuntu 17.04). Congratulations!

asensi moved this task from In progress to Done on the Krusader board.Aug 28 2017, 11:03 PM