the changes are working as expected.
Sep 5 2017
Aug 5 2017
Aug 1 2017
Jul 23 2017
I have also added the changes of D6788 with arc in the previous diff ... :(
FIXED:  Edit field looses focus after closing one of Editor's/Viewer's tab
FIXED:  KrViewer window loses focus on closing tabs
Jul 22 2017
Jul 19 2017
Jul 11 2017
I would like to solve this issue
Jul 8 2017
Update after review. DiskUsage dialog non-modal. Segmentation fault fixed.
Jul 5 2017
is a good solution (StackOverflow is your friend:) https://stackoverflow.com/q/20491864/6286694) . You can do this inside the constructor.
And a matter of taste is keeping the parent argument for the constructor (keep MAIN_VIEW instead of 0). This will make the dialog a child the mainwindow but with show() it will not block. If you don't like this (I don't care) the parent parameter should be removed.
For Search and Locate only one dialog instance is created. SynchronizerGUI has indeed the same problem (for the last 7+ years). And krusader/UserAction/expander.cpp:702 looks strange.
Update after review
Jul 4 2017
Jul 2 2017
I would like to solve this issue (patch already submitted)
My opinion: Disk Usage window should be a regular window (like text editor - F3/F4). So user has the option to see more then one Disk Usage windows at the same time.
The current state is kind of half-way there. It is possible to see more then one Disk Usages but it is not a regular window.
But if it would be too difficult to rework, I'm fine with modal dialog.